-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion: re-consider the deprecation of some IO-related APIs #4120
Comments
This makes sense to me as Web Stream doesn't completely cover what Reader(Sync)/Writer(Sync)/Closer does. |
@ry What do you think? |
I've created #4128 to see what this could look like. |
Discussed with the CLI team and everyone agrees that it makes sense to keep these APIs in |
I often saw people find |
I think there's an argument for Doing so, I think, would cover all the most basic modalities for these I/O interfaces and methods (read, write, copy and store). |
std/io
is being deprecated because theDeno.Reader
interface and friends are being deprecated from the runtime. However, theirread()
,write()
, and other methods on I/O-related APIs, such asDeno.FsFile
andDeno.Conn
, are here to stay. These methods staying around justify keeping some IO-related APIs within the Standard Library instead of deprecating them.To keep the Standard Library and its maintenance lean, I suggest we keep APIs that allow converting
Reader
s andWriter
s to streams. This will need some more review, but, at first glance, I think we should un-deprecate:readAll()
readableStreamFromReader()
writeAll()
writableStreamFromWriter()
CC @bartlomieju, @piscisaureus and @kt3k
The text was updated successfully, but these errors were encountered: