Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Testing #306

Closed
zekth opened this issue Mar 26, 2019 · 3 comments
Closed

[Discussion] Testing #306

zekth opened this issue Mar 26, 2019 · 3 comments

Comments

@zekth
Copy link
Contributor

zekth commented Mar 26, 2019

I have some concerns about testing. At the moment everytime we encounter a failing test it exit without testing all the tests cases. This is due to:
https://github.com/denoland/deno_std/blob/master/testing/mod.ts#L12

EDIT: Merged in #307

Which is not mutable. Do we add it as a parameter for the runTests() method? I personnaly prefer to have a total report of failing tests instead of debugging them one by one.

Also for readability i would purpose to change the prompt from:

test [TOML] CRLF ... ok
test [TOML] Boolean ... ok
test [TOML] Integer ... ok
test [TOML] Float ... FAILED

to

OK   [TOML] CRLF
OK   [TOML] Boolean
OK   [TOML] Integer
FAIL [TOML] Float

This makes it easier to read and also easier to parse, like used in the gitlab CI for coverage and so on. Ref: https://docs.gitlab.com/ee/user/project/pipelines/settings.html#test-coverage-parsing

@ry
Copy link
Member

ry commented Mar 26, 2019

You may submit a PR to turn off exitOnFail.

@bartlomieju
Copy link
Member

This was done in #307?

@zekth
Copy link
Contributor Author

zekth commented May 6, 2019

This was done in #307?

Yes. Keeping it open with #314

@zekth zekth closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants