Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): respect "typescript.preferences.quoteStyle" when deno.json is absent #20891

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Closes #15487.

Also better aligns the defaults passed to tsc format settings with deno fmt.

@nayeemrmn nayeemrmn requested a review from bartlomieju October 12, 2023 13:24
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM!

@nayeemrmn nayeemrmn merged commit 659cd90 into denoland:main Oct 17, 2023
12 checks passed
@nayeemrmn nayeemrmn deleted the lsp-tsc-default-fmt-options branch October 17, 2023 01:52
@johnspurlock
Copy link
Contributor

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lsp: does not honor "typescript.preferences.quoteStyle" when adding imports
3 participants