🙏🏻 [feat/req] Implement signal handlers for Windows

[rivy]

Currently, all the available signal handling API throw "unimplemented" errors for Windows platforms.

It would be great to have cross-platform signal handling along the lines of NodeJS Process Signal Events...

// ...works in NodeJS...

[`SIGBREAK`, `SIGINT`, `SIGUSR1`, `SIGUSR2`, `uncaughtException`, `SIGTERM`].forEach((eventType) => {
	process.on(eventType, catchSignal.bind(null, eventType));
});
[`exit`].forEach((eventType) => {
	process.on(eventType, catchExit.bind(null, eventType));
});

function catchSignal(eventType) {
	console.log('Caught signal...', { eventType });
}
function catchExit(eventType) {
	console.log('Now exiting...', { eventType });
}

setTimeout(() => {
	console.log('The service is now finished.');
}, 2000);

[rivy]

There is a stalled partial implementation (Windows CTRL-C/CTRL-BREAK (SIGINT/SIGBREAK) signal handler).

related

• Signal Handlers/discussion
• Initial signal handling (non-Windows) implementation
• Signal syntactic sugar implementation

[rivy]

😃
Yeah! There's some revived signal handling work going on in #14694.

[swiftsword94]

When testing with a generated prisma client(without windows) it seems like the following signals break on windows when adding the signal listeners: SIGUSR2, SIGINT, SIGTERM, beforeExit, exit.

this is when using createrequire via "node:module" and importing the generated client

Uncaught TypeError: Windows only supports ctrl-c (SIGINT) and ctrl-break (SIGBREAK).
    at bindSignal (ext:runtime/40_signals.js:16:14)
    at Object.addSignalListener (ext:runtime/40_signals.js:56:19)
    at process.on (ext:deno_node/process.ts:293:22)
    at process.once (ext:deno_node/_events.mjs:525:8)

Should similar functionality to nodejs be made for these signals?

[BlackGlory]

I encountered this error on deno 1.39.1.

import puppeteer from 'npm:[email protected]'

await puppeteer.launch({
  executablePath: 'chrome'
})

error: Uncaught (in promise) TypeError: Windows only supports ctrl-c (SIGINT) and ctrl-break (SIGBREAK).

This works:

import puppeteer from 'npm:[email protected]'

await puppeteer.launch({
  executablePath: 'chrome'
, handleSIGHUP: false
, handleSIGTERM: false
})

[guillaume86]

The handleSIGTERM: false is not required, only handleSIGHUP ;).