Deno.Buffer.readFrom(Sync) methods void exceptions

[SyrupThinker]

deno/cli/js/buffer.ts

Lines 180 to 192 in 93c2164

	try {
	const i = this.#grow(MIN_READ);
	this.#reslice(i);
	const fub = new Uint8Array(this.#buf.buffer, i);
	const nread = r.readSync(fub);
	if (nread === null) {
	return n;
	}
	this.#reslice(i + nread);
	n += nread;
	} catch (e) {
	return n;
	}

This masks failures in read functions and can manifest like in #4789 where an empty buffer is returned instead.

deno 1.0.0
v8 8.4.300
typescript 3.9.2
(master build)

[caspervonb]

Anyone working on this? If not I'll take it on as it relates to #6121 which I'm working on

[bartlomieju]

@caspervonb go ahead, this issue hasn't been claimed yet