Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to skip type checking of remote modules #5460

Closed
dsherret opened this issue May 15, 2020 · 5 comments
Closed

Ability to skip type checking of remote modules #5460

dsherret opened this issue May 15, 2020 · 5 comments
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)

Comments

@dsherret
Copy link
Member

dsherret commented May 15, 2020

The TS compiler has a --skipLibCheck compiler option that allows skipping type checking of declaration files.

Similarly, it might be nice for Deno to:

  1. Have a way to not type check the private implementations of remote modules or make this the default (this would help with compile times too).

  2. Have something like the --skipLibCheck compiler option that skips type checking of remote modules completely or have a way to do this on a case-by case basis. Example, in deps.ts people could add a comment above the import:

    // @ts-skip-check
    export * as myProject from "https://deno.land/x/my-project/etc....";
    

The reason why this would be nice is because remote modules are often out of our control and we might want to depend on an old version of a dependency that now has type checking errors in the current version of the TS compiler being used.

@nayeemrmn
Copy link
Collaborator

nayeemrmn commented May 15, 2020

I suggest something like:

    --no-check=<all|remote|none|<blacklist>...>
        Skip type checking for the specified modules (default: remote)

(The "default" is chosen when the option isn't given. If it is given, it requires a value.)

@bartlomieju bartlomieju added cli related to cli/ dir feat new feature (which has been agreed to/accepted) labels May 15, 2020
@bartlomieju
Copy link
Member

@kitsonk what's your take on this issue?

@kitsonk
Copy link
Contributor

kitsonk commented May 17, 2020

It seems like a lot of work which would cause a level of confusion. I think we should land the binary capability to skip type checking and live with that for a while before making the whole thing more complicated.

@bartlomieju
Copy link
Member

It seems like a lot of work which would cause a level of confusion. I think we should land the binary capability to skip type checking and live with that for a while before making the whole thing more complicated.

So --no-type-check flag that has global effect 👍 makes sense for a first pass

@bartlomieju
Copy link
Member

--no-check option landed in #6456, will be released in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)
Projects
None yet
Development

No branches or pull requests

4 participants