Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno remove/uninstall subcommand #3139

Closed
mhvsa opened this issue Oct 17, 2019 · 38 comments · Fixed by #12209
Closed

deno remove/uninstall subcommand #3139

mhvsa opened this issue Oct 17, 2019 · 38 comments · Fixed by #12209
Labels
cli related to cli/ dir suggestion suggestions for new features (yet to be agreed)

Comments

@mhvsa
Copy link
Contributor

mhvsa commented Oct 17, 2019

We've got deno install and it would be convenient to also have deno remove or deno uninstall subcommand

@bartlomieju
Copy link
Member

We had uninstall but removed it
denoland/std#512 (comment)

@mhvsa
Copy link
Contributor Author

mhvsa commented Oct 17, 2019

oh, thank you

for myself rm $(which foo) works but I think it made sense to keep the uninstall

closing

@mhvsa mhvsa closed this as completed Oct 17, 2019
@roc
Copy link

roc commented May 7, 2020

Just landed in deno land and I was absolutely baffled there's no uninstall or rm command! Is the reason that you expect a single location for something to be installed, a single version as well? I find it confusing to have an API that has a way of adding something but not of removing it.

@willgm
Copy link

willgm commented May 14, 2020

@mhvsa

for myself rm $(which foo) works but I think it made sense to keep the uninstall

What about Windows users? Much of the Deno users may not know enough of his system terminal to remove it, and in the end feel lost about it.

I believe Deno should have a command to undo something that his own command have made.

@Yamboy1
Copy link

Yamboy1 commented May 14, 2020

Even as a linux user I would prefer a specific command to do this rather than having to mess around with shell expansions and the such

@bartlomieju bartlomieju reopened this May 14, 2020
@nateshmbhat
Copy link

oh, thank you

for myself rm $(which foo) works but I think it made sense to keep the uninstall

closing

The issue with rm $(which foo) is that , people can have other binaries than the ones from deno that have the same name as deno binaries. This can happen when the DENO path is suffixed to the system PATH instead of "prefixing".

So we need a deno uninstall command that will only look in the DENO path and remove the required files

@llluuulll
Copy link

llluuulll commented Jun 2, 2020

hi,
so what command i can use to uninstall Deno ? i am on wondows 10 and i am not at all confortable with complet unknow commands, i dont understand.

rm $(witch foo), what is it wich foo ?
can some one point me the correct typo command to use ?

thx.

@ry
Copy link
Member

ry commented Jun 2, 2020

The issue with rm $(which foo) is that , people can have other binaries than the ones from deno that have the same name as deno binaries. This can happen when the DENO path is suffixed to the system PATH instead of "prefixing".

Thanks - good argument.

I'm ok with something like this:

deno install --delete foo

@stefnotch
Copy link

I'd absolutely prefer deno uninstall over adding a delete flag to an install command. The latter seems like a odd hack and is going to cause a lot of googling and confusion for newcomers.

@lem0nify
Copy link

Return uninstall subcommand!

deno uninstall foo is much more elegant than navigating to and removing the script by hand!

@trivikr
Copy link
Contributor

trivikr commented Jul 27, 2020

I agree that uninstall is a better option, as it's opposite of install - similar to npm install and npm uninstall

The command remove is opposite of add - similar to yarn add and yarn remove
The command delete is antonym of insert - similar to insertion and deletion in data structures.

deno uninstall should be preferred opposite for deno install

@whatevergeek
Copy link

i guess while this is still on discussion, we'll have to manage this manually by deciding which ones to delete under the deno folder.
e.g. on Windows 10, C:\Users<user>\AppData\Local\deno

@lem0nify
Copy link

@whatevergeek C:/Users/USERNAME/.deno/bin, IIRC.
But it's still not the most comfortable place to navigate.

Of course, uninstall subcommand is mostly needed in Windows, because Windows users are used to navigate and manage files with Explorer. By default, there is not even a shortcut to the home folder in Windows 10 Explorer and files/folders starting with dot are hidden. Of course, I know I can create my own shortcut and change file hiding policy, but it's weird and unnaturally that deno forces me do it instead of providing a way to uninstall with one simple command what was installed with one simple command.

To be honest, I do not see any objective reason to remove the uninstall subcommand, even if it seemed to someone unnecessary. How could its presence interfere to someone?

@llluuulll
Copy link

i am totally agee with @lem0nify
his comment resume perfectly the point

@wyrd-code
Copy link

I agree, this is an issue for me as well.

Take this case for example, I previously installed denon to use local development with a watcher. Now that Deno supports --watch, I upgraded and denon stopped working. Then I tried to upgrade the denon script but I don't see any commands to do that anywhere. After I realized I need to remove it manually (sic), I did a rm -rf ~/.deno/bin/denon. Trying to install it again now fails and I seem to be stuck with a message "error: No such file or directory (os error 2)".

If you remove a command like uninstall, the least you can do is refer to it in documentation, explaining why it was removed and how to handle the use case manually.

@David-Else
Copy link

This seems crazy! Where is the uninstall command?

@ChoqueCastroLD
Copy link

An uninstall command is the most intuitive thing to do instead of a flag

It will help a lot of newcomers to deno and people who are not so familiarized with their own terminal (windows users mostly)

@picode7
Copy link

picode7 commented Jan 5, 2021

Solution when running on Windows:

rm $HOME/.deno/bin/myscript.cmd

https://stackoverflow.com/a/62259110/4339170

Please add an uninstall command that works for any system and user command-line knowledge.

@michaeldesu
Copy link

FWIW an uninstall process for Windows would be appreciated, since I'm on a PC where I need admin-password to do simple things like allow firewall updates. Installing deno was no problem (I had to cancel the admin-controlled firewall/policy update requested by deno post-install) but when I tried to do a upgrade to 1.7, I was blocked by the firewall, so I need to uninstall & reinstall.

@crowlKats
Copy link
Member

@michaeldesu this feature request is about having a uninstall command for scripts installed through deno install, not a way to uninstall deno itself

@michaeldesu
Copy link

apologies for that

@einarpersson
Copy link

Having to google deno uninstall and coming here is a unnecessary hurdle for a new user.

  • If you provide install an uninstall is expected.
  • If the naming had been add then remove had been expected.

It is great that the uninstall is really simple under the hood (rm $(which foo)) but that does not change the point(s) above at all.

Please reconsider

@stale
Copy link

stale bot commented May 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 5, 2021
@stefnotch
Copy link

Could we please not mark highly upvoted issues as stale?

@stale stale bot removed the stale label May 6, 2021
@llluuulll
Copy link

Totally agree with einarpersson
Do Deno will consider having a uninstall ?

And also same as stefnotch
Why close an issue if we dont know if is resolve or not

@merlindru
Copy link

Here from google, big +1

@lucacasonato lucacasonato added cli related to cli/ dir suggestion suggestions for new features (yet to be agreed) labels Jun 8, 2021
@UltiRequiem
Copy link
Contributor

PLEASE!

@jcaru
Copy link

jcaru commented Sep 23, 2021

I would just like to point out the relevancy of this feature. I personally can't recommend anyone install any software I write for Deno via the install subcommand because the feature is incomplete in that it would require I provide multiple, OS-specific uninstallation commands, rather than the intuitive uninstall subcommand. This looks clunky at best, and unprofessional at worst.

I absolutely love Deno, but I can't make the leap to switch entirely over knowing that an uninstall subcommand is currently not a feature. Just as an uninstall subcommand is unnecessary, computers too are unnecessary. Technology is to improve overall productivity, not to hinder it. The lack of an uninstall subcommand because it is unnecessary is akin to opting to write a simple, headless program in assembly because the cross-platform C standard library isn't mandatory to achieve the task.

Deno has achieved so much that Node lacked. Deno may be small, but the software we write with it isn't always as sleek (do >100 MB Electron apps sound familiar?), and what better way to uninstall the app than the intuitive compliment to the graceful deno install, deno uninstall?

Please reconsider, and thank you for bringing Deno into our dev lives :)

@crowlKats
Copy link
Member

uninstall subcommand is too much to ask

It isnt "too much to ask", just not a priority.

@jcaru
Copy link

jcaru commented Sep 23, 2021

Ah, thanks for clarifying @crowlKats. Editing now :)

@bartlomieju
Copy link
Member

We'll be happy to consider a PR that adds this feature.

It worth pointing out that it should fail gracefully if a Deno script was not installed in the default location, and suggest appropriate action in that case.

@dcj9
Copy link

dcj9 commented Dec 16, 2021

sill nothin eh?

@dsherret
Copy link
Member

@dcj9 it was released in 1.15.

@ritamgit-alt
Copy link

How uninstall deno in mac?
any command or something?

@stefnotch
Copy link

deno uninstall some-script-name works with modern versions of Deno

@ritamgit-alt
Copy link

nope not working with mine

@dsherret
Copy link
Member

This issue is not about uninstalling Deno. It's about uninstalling commands installed with deno install

@ritamgit-alt
Copy link

so what should I do now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.