Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX support #3037

Closed
keroxp opened this issue Sep 29, 2019 · 1 comment
Closed

JSX support #3037

keroxp opened this issue Sep 29, 2019 · 1 comment

Comments

@keroxp
Copy link
Contributor

keroxp commented Sep 29, 2019

I'm happy if JSX is supported by default. JSX is useful template engine for the server side. TypeScript officially supports JSX and have its transformation options --jsx --jsxFactory.

Currently Deno emits errors when compiling .tsx file even tough providing custom tsconfig.json file (It seems to be ignored 🤔).

On the server side usage, we don't need ReactDOM.render function that is based on DOM and only ReactDOMServer.renderToString like function is needed.

So, how about adding basic jsx transformer to xml string in Deno?
Default compiler options will be like below:

"jsx": "react",
"jsxFactory": "Deno.h"
@keroxp keroxp mentioned this issue Sep 30, 2019
Merged
@ry
Copy link
Member

ry commented Oct 2, 2019

fixed in #3038

@ry ry closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ry @keroxp