Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No types for node builtin modules in LSP #24401

Closed
nathanwhit opened this issue Jul 2, 2024 · 5 comments · Fixed by #24404
Closed

No types for node builtin modules in LSP #24401

nathanwhit opened this issue Jul 2, 2024 · 5 comments · Fixed by #24404
Assignees
@nayeemrmn
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@nathanwhit
Copy link
Member

nathanwhit commented Jul 2, 2024 •
edited
Loading

Regressed in #24206.

(This is in a basic project with an empty deno.json and just a main.ts that imports from node:process)

On the previous commit:

❯ deno upgrade --canary --version 341913319c1167011d71d899a101824c8fae86c2
❯ deno --version
deno 1.44.2+3419133 (canary, aarch64-apple-darwin)

Screenshot 2024-07-02 at 2 48 08 PM

After PR merged (and the same in 1.44.4 and latest canary):

❯ deno upgrade --canary --version 5dec3fd4b75a59574e5aeed4e927d8e3e0c1c683
❯ deno --version
deno 1.44.2+5dec3fd (canary, aarch64-apple-darwin)

Screenshot 2024-07-02 at 2 47 44 PM
@nathanwhit nathanwhit added bug Something isn't working correctly lsp related to the language server labels Jul 2, 2024
@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Jul 3, 2024 •
edited
Loading

What's the project configuration / structure?

Edit: Was able to reproduce the issue, weirdly it doesn't work for me on 1.44.2 either though.

@nayeemrmn nayeemrmn self-assigned this Jul 3, 2024
@nayeemrmn

This comment was marked as resolved.

Sign in to view
@Hajime-san

This comment was marked as resolved.

Sign in to view
@nayeemrmn
Copy link
Collaborator

@Hajime-san Please check on deno upgrade --canary, that issue should be fixed already.

@Hajime-san
Copy link
Contributor

Thanks! It seems to be fixed in canary.

@nayeemrmn nayeemrmn mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nayeemrmn nayeemrmn

Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): correct scope attribution for injected @types/node nayeemrmn/deno
3 participants
@nathanwhit @nayeemrmn @Hajime-san