Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node compatibility] undici as http socketPath workaround, now not working at version 5.26.3, may due to tls.connect highWaterMark #20928

Closed
loynoir opened this issue Oct 18, 2023 · 1 comment

Comments

@loynoir
Copy link

loynoir commented Oct 18, 2023

Background

Reproduce

import { describe, it } from "https://deno.land/[email protected]/testing/bdd.ts";
import {
  fetch as undiciFetch,
  // getGlobalAgent, setGlobalAgent, Agent
// } from "npm:[email protected]";
} from "npm:[email protected]";

describe("reproduce", () => {
  it("reproduce", async () => {
    // const agent = new Agent()
    // setGlobalAgent(agent)
    const resp = await undiciFetch("https://unpkg.com");
    await resp.text();
    // await agent.destroy()
  });
});
error: TypeError: fetch failed
    at fetch (file:///home/vscode/.cache/deno/npm/x-registry-yarnpkg-com/undici/5.26.3/index.js:110:15)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async Object.<anonymous> (file:///tmp/x.ts:7:18)
    at async Function.runTest (https://deno.land/[email protected]/testing/_test_suite.ts:358:7)
    at async Function.runTest (https://deno.land/[email protected]/testing/_test_suite.ts:346:9)
    at async fn (https://deno.land/[email protected]/testing/_test_suite.ts:316:13)
Caused by: AssertionError
    at new AssertionError (ext:deno_node/assertion_error.ts:414:11)
    at toNode (node:assert:44:15)
    at assert (node:assert:61:3)
    at new Parser (file:///home/vscode/.cache/deno/npm/x-registry-yarnpkg-com/undici/5.26.3/lib/client.js:568:5)
    at connect (file:///home/vscode/.cache/deno/npm/x-registry-yarnpkg-com/undici/5.26.3/lib/client.js:1269:25)

Related

@loynoir loynoir changed the title [node compatibility] [email protected] [node compatibility] undici as http socketPath workaround, now not working at version 5.26.3 Oct 18, 2023
@loynoir loynoir changed the title [node compatibility] undici as http socketPath workaround, now not working at version 5.26.3 [node compatibility] undici as http socketPath workaround, now not working at version 5.26.3, due to tls.connect highWaterMark Oct 18, 2023
@loynoir loynoir changed the title [node compatibility] undici as http socketPath workaround, now not working at version 5.26.3, due to tls.connect highWaterMark [node compatibility] undici as http socketPath workaround, now not working at version 5.26.3, may due to tls.connect highWaterMark Oct 18, 2023
@loynoir
Copy link
Author

loynoir commented Oct 18, 2023

Close in favor of a cleaner issue.

@loynoir loynoir closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant