Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno 1.37 lsp no longer works with Helix #20900

Closed
lluchs opened this issue Oct 13, 2023 · 2 comments
Closed

Deno 1.37 lsp no longer works with Helix #20900

lluchs opened this issue Oct 13, 2023 · 2 comments

Comments

@lluchs
Copy link

lluchs commented Oct 13, 2023

I'm using deno lsp with minimal configuration in Helix 23.05 as follows:

[[language]]                                             
name = "typescript"                                      
language-server = { command = "deno", args = ["lsp"] }   
config = { enable = true }                               

With Deno 1.36.0, everything worked fine. I got the following output:

"Starting Deno language server...\n"
"  version: 1.36.0 (release, x86_64-unknown-linux-gnu)\n"
"  executable: /usr/local/bin/deno\n"
"Connected to \"helix\" 23.05 (7f5940be)\n"
"Server ready.\n"
"Error converting specifier settings (file://...): Error converting specifier settings: invalid type: null, expected struct SpecifierSettings\n"
"failed to update settings: invalid type: null, expected struct WorkspaceSettings\n"

With Deno 1.37.1 and 1.37.2, nothing works (i.e., no completion, no diagnostics, no commands) and I'm getting the following output:

"Starting Deno language server...\n"
"  version: 1.37.2 (release, x86_64-unknown-linux-gnu)\n"
"  executable: /usr/local/bin/deno\n"
"Connected to \"helix\" 23.05 (7f5940be)\n"
"Server ready.\n"
"Error converting specifier settings (file://...): Error converting specifier settings: invalid type: null, expected struct SpecifierSettings\n"

Might be related to the fix in #14455?

@sigmaSd
Copy link
Contributor

sigmaSd commented Oct 13, 2023

That config used to be accepted by deno somehow even if its not correct, seems like its a hard error now

The correct config is config = { deno = { enable = true } }

@nayeemrmn
Copy link
Collaborator

@lluchs Please comment if the above config doesn't work for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants