Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in dependency inspector #2021

Closed
mathiasbynens opened this issue Mar 30, 2019 · 5 comments
Closed

Bug in dependency inspector #2021

mathiasbynens opened this issue Mar 30, 2019 · 5 comments
Labels
bug Something isn't working correctly
Milestone

Comments

@mathiasbynens
Copy link

@cdata reported the following resolution error for a module graph that fully resolves in Chrome:

$ deno --info https://unpkg.com/@google/[email protected]/lib/model-viewer.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/model-viewer.js?module
Downloading https://unpkg.com/@google/[email protected]/lib/features/animation.js?module
Downloading https://unpkg.com/lit-element@^2.0.0?module
Downloading https://unpkg.com/lit-html@^1.0.0?module
Downloading https://unpkg.com/lib/default-template-processor.js?module
Cannot resolve module "./lib/default-template-processor.js?module" from "https://unpkg.com/lit-html@^1.0.0?module"
@ry ry added this to the v0.4 milestone Mar 30, 2019
@ry ry added the bug Something isn't working correctly label Mar 30, 2019
@cdata
Copy link

cdata commented Mar 31, 2019

This was tested on a Mac, if it helps.

@kt3k
Copy link
Member

kt3k commented Mar 31, 2019

This seems like the same bug as this one.

https://unpkg.com/lit-html@^1.0.0?module redirects to https://unpkg.com/[email protected]/lit-html.js?module, but deno tries to resolve ./lib/default-template-processor.js?module from https://unpkg.com/, not https://unpkg.com/[email protected]/.

@ry
Copy link
Member

ry commented Apr 2, 2019

Unfortunately still broken

> ./target/debug/deno https://unpkg.com/@google/[email protected]/lib/model-viewer.js?module
https://unpkg.com/[email protected]/lib/updating-element.js?module:74:37
export class UpdatingElement extends HTMLElement {
                                     ^
Uncaught ReferenceError: HTMLElement is not defined
    at https://unpkg.com/[email protected]/lib/updating-element.js?module:74:38

But it's no longer the redirect error - we just don't have HTMLElement in there...

@kt3k
Copy link
Member

kt3k commented Apr 2, 2019

I think this issue can be closed because --info option now works for the given url https://unpkg.com/@google/[email protected]/lib/model-viewer.js?module and the entire dependency tree is visible. ( log )

@ry
Copy link
Member

ry commented Apr 2, 2019

Ok closing. Didn’t realize my above command was missing —info 🤦🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants