Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Moving/renaming a file does not update import paths #17821

Open
jespertheend opened this issue Feb 19, 2023 · 4 comments
Open

lsp: Moving/renaming a file does not update import paths #17821

jespertheend opened this issue Feb 19, 2023 · 4 comments

Comments

@jespertheend
Copy link
Contributor

When using the TypeScript language server, you can move or rename files and it will automatically update import paths from all files that use that module. But when using the Deno extension this does not seem to be working for me.

@sigmaSd
Copy link
Contributor

sigmaSd commented Feb 20, 2023

As far I remember that's not builtin to typescript lsp but in vscode itself, they discussed moving this feature to the server but then decided that's not really worth it because all the work happens on the client

So probably deno would need also to do the same, as in add this feature to the clients vscode-deno for example

@jespertheend
Copy link
Contributor Author

Ah that's unfortunate, I wonder what's causing vscode to disable the functionallity then.
I found some renaming functionality in TypeScript: microsoft/TypeScript#23573
But I'm not sure if that's useful at all.

@sigmaSd
Copy link
Contributor

sigmaSd commented Feb 20, 2023

Here is the relevant issue typescript-language-server/typescript-language-server#641

@scarf005
Copy link
Contributor

scarf005 commented May 19, 2023

would it be possible to implement this feature in deno LSP using current vscode API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants