-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vendoring modules which read "static" files, like .wasm
#14123
Comments
Hmmm... vendoring remote modules that read "static" files would be complex, but I can see the need. @dsherret thoughts? |
.wasm
file.wasm
Noticed this problem today when trying to vendor eszip:
Since https://deno.land/x/[email protected]/eszip_wasm_bg.wasm isn't downloaded, the vendored version of eszip is broken. |
I believe this will have to wait for #2552 |
Any update on this? |
I believe we need to wait for Import Attributions (a.k.a Import Assertions). |
Actually, yeah this would be supported by #2552. For now, this can be solved by manually running a custom post-vendoring step to download the necessary .wasm files. |
I don't think there's anything actionable in this issue. With Wasm modules this now works, but they need to be imported using Wasm imports. For static files, follow #25354 |
@dsherret Ah, my bad — you're saying that when WASM support landed, WASM vendoring support landed too? In that case, carry on :) |
I would like to
deno vendor
a module that uses WebAssembly (WASM). It is compiled usingwasm-bindgen
so there is a directory structure like this:The
.js
file contains glue code that calls into the.wasm
file. It is vendored successfully but tries to fetch the WASM from a URL like this:Unfortunately, after vendoring the URL points to a path in the local filesystem, but nothing is there because the
.wasm
file isn't brought over. So it is not possible to run the module locally after vendoring.The text was updated successfully, but these errors were encountered: