Skip to content

Commit 960776c

Browse files
satyarohithkt3kbartlomiejucrowlKats
authored
fix(ext/node): support createConnection option in node:http.request() (#25470)
This commit changes "node:http" module to add support for the "createConnection" option when the "request()" API is called. Closes #19507 --------- Signed-off-by: Yoshiya Hinosawa <[email protected]> Signed-off-by: Satya Rohith <[email protected]> Co-authored-by: Yoshiya Hinosawa <[email protected]> Co-authored-by: Bartek Iwańczuk <[email protected]> Co-authored-by: crowlkats <[email protected]>
1 parent a63f845 commit 960776c

21 files changed

+465
-597
lines changed

ext/fetch/lib.rs

-3
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,6 @@ pub enum FetchError {
206206
RequestBuilderHook(deno_core::error::AnyError),
207207
#[error(transparent)]
208208
Io(#[from] std::io::Error),
209-
// Only used for node upgrade
210-
#[error(transparent)]
211-
Hyper(#[from] hyper::Error),
212209
}
213210

214211
pub type CancelableResponseFuture =

ext/node/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -364,9 +364,9 @@ deno_core::extension!(deno_node,
364364
ops::zlib::brotli::op_create_brotli_decompress,
365365
ops::zlib::brotli::op_brotli_decompress_stream,
366366
ops::zlib::brotli::op_brotli_decompress_stream_end,
367-
ops::http::op_node_http_request<P>,
368367
ops::http::op_node_http_fetch_response_upgrade,
369-
ops::http::op_node_http_fetch_send,
368+
ops::http::op_node_http_request_with_conn<P>,
369+
ops::http::op_node_http_await_response,
370370
ops::http2::op_http2_connect,
371371
ops::http2::op_http2_poll_client_connection,
372372
ops::http2::op_http2_client_request,

0 commit comments

Comments
 (0)