comment + only if has scripts

Author: nathanwhit

cli/npm/managed/resolvers/common/lifecycle_scripts.rs

@@ -62,7 +62,7 @@ impl<'a> LifecycleScripts<'a> {
   }
 }
 
-fn has_lifecycle_scripts(
+pub fn has_lifecycle_scripts(
   package: &NpmResolutionPackage,
   package_path: &Path,
 ) -> bool {
@@ -277,6 +277,10 @@ impl<'a> LifecycleScripts<'a> {
         self.strategy.did_run_scripts(package)?;
       }
 
+      // re-set up bin entries for the packages which we've run scripts for.
+      // lifecycle scripts can create files that are linked to by bin entries,
+      // and the only reliable way to handle this is to re-link bin entries
+      // (this is what PNPM does as well)
       bin_entries.finish_only(
         snapshot,
         &root_node_modules_dir_path.join(".bin"),

cli/npm/managed/resolvers/local.rs

@@ -664,8 +664,13 @@ async fn sync_resolution_with_fs(
       |setup_outcome| {
         match setup_outcome {
           bin_entries::EntrySetupOutcome::MissingEntrypoint {
-            package, ..
-          } if lifecycle_scripts.can_run_scripts(&package.id.nv)
+            package,
+            package_path,
+            ..
+          } if super::common::lifecycle_scripts::has_lifecycle_scripts(
+            package,
+            package_path,
+          ) && lifecycle_scripts.can_run_scripts(&package.id.nv)
             && !lifecycle_scripts.has_run_scripts(package) =>
           {
             // ignore, it might get fixed when the lifecycle scripts run.