Skip to content

Fix WithPath to handle URL-encoded characters #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dennisdoomen merged 5 commits into from
Dec 31, 2025
Merged

Fix WithPath to handle URL-encoded characters #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46b7c59
Initial plan
Copilot Dec 30, 2025
e866ec2
Add URL encoding support for WithPath() to handle special characters
Copilot Dec 30, 2025
b4dd282
Address code review feedback: improve PathEncodedChars definition and…
Copilot Dec 30, 2025
5efb02c
Address PR feedback: preserve ? wildcard, move tests to HttpMockSpecs…
Copilot Dec 30, 2025
5fd787c
Simplify approach: decode path before matching instead of encoding pa…
Copilot Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions Mockly.Specs/HttpMockSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,45 @@ public async Task The_query_does_not_require_a_question_mark()
response.StatusCode.Should().Be(HttpStatusCode.OK);
}

[Fact]
public async Task Can_match_path_with_pipe_character()
{
// Arrange
var mock = new HttpMock();
var key = $"{Guid.NewGuid()}|{Guid.NewGuid()}";

mock.ForDelete()
.WithPath($"IncomeRelations/{key}")
.RespondsWithStatus(HttpStatusCode.OK);

// Act
var client = mock.GetClient();
var response = await client.DeleteAsync($"https://localhost/IncomeRelations/{key}");

// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
}

[Fact]
public async Task Can_match_query_with_pipe_character()
{
// Arrange
var mock = new HttpMock();
var filter = "status=active|pending";

mock.ForGet()
.WithPath("api/items")
.WithQuery($"filter={filter}")
.RespondsWithStatus(HttpStatusCode.OK);

// Act
var client = mock.GetClient();
var response = await client.GetAsync($"https://localhost/api/items?filter={filter}");

// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
}

[Fact]
public async Task Can_mock_get_request_with_json_response()
{
Expand Down
2 changes: 1 addition & 1 deletion Mockly/RequestMock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public async Task<bool> Matches(RequestInfo request)
// Check path pattern if specified
if (PathPattern != null)
{
var path = request.Uri?.AbsolutePath ?? string.Empty;
var path = WebUtility.UrlDecode(request.Uri?.AbsolutePath ?? string.Empty);
if (!MatchesPattern(path.TrimStart('/'), PathPattern.TrimStart('/')))
{
return false;
Expand Down