Pre-empted message should not be sent in scout simply because majority hasn't been reached yet?

[ChengSashankh]

Perhaps this is just about indentation in the if blocks, but scout.py in state-reduction shouldn't send PreEmptedMessage while checking for majority.

Current:

if isinstance(msg, P1bMessage):
        if self.ballot_number == msg.ballot_number and msg.src in waitfor:
          pvalues.update(msg.accepted)
          waitfor.remove(msg.src)
          if (2 * len(waitfor)) > len(self.acceptors):
            self.sendMessage(self.leader, AdoptedMessage(self.me, self.ballot_number, pvalues))
            return
          else:
            self.sendMessage(self.leader, PreemptedMessage(self.me, msg.ballot_number))
            return
        else:
          print "Scout: unexpected msg"

Likely should be:

if isinstance(msg, P1bMessage):
        if self.ballot_number == msg.ballot_number and msg.src in waitfor:
          pvalues.update(msg.accepted)
          waitfor.remove(msg.src)
          if (2 * len(waitfor)) > len(self.acceptors):
            self.sendMessage(self.leader, AdoptedMessage(self.me, self.ballot_number, pvalues))
            return
        else:
          self.sendMessage(self.leader, PreemptedMessage(self.me, msg.ballot_number))
          return
else:
  print "Scout: unexpected msg"