Xcode 13 Compatibility and Doing Validation Eariler #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work on this @insha! I haven't had a chance to review the bulk of your PR in doing the validation earlier, but I will get to it the next time I am focusing on doing some improvements. In the meantime, I'm going to do a separate commit for Xcode 13. |
dempseyatgithub
force-pushed
the
main
branch
from
b6f86d6 to
d4cb886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for issues #66 and #67 is accomplished by extracting the project setting logic into its own class and using a closure to defer processing until project settings have been validated.
The fix for #82 is fairly straight forward and only the set needed to be updated to include "Xcode 13.0".
This also adds a git ignore file.
Closes #82
Closes #67
Closes #66