From a9d9f67621cb587ec8781fde21fc55d7ba84854e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 11 Dec 2025 19:38:11 +0000 Subject: [PATCH 1/4] Initial plan From fa202e6ca1f783f5256d1b66f242cbaefad7a688 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 11 Dec 2025 19:44:41 +0000 Subject: [PATCH 2/4] Add explicit #nullable enable directive to all C# files Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> --- src/DemaConsulting.TestResults/IO/TrxSerializer.cs | 2 ++ src/DemaConsulting.TestResults/TestOutcome.cs | 2 ++ src/DemaConsulting.TestResults/TestResult.cs | 2 ++ src/DemaConsulting.TestResults/TestResults.cs | 2 ++ test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs | 2 ++ test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs | 2 ++ test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs | 2 ++ test/DemaConsulting.TestResults.Tests/TestHelpers.cs | 2 ++ test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs | 2 ++ 9 files changed, 18 insertions(+) diff --git a/src/DemaConsulting.TestResults/IO/TrxSerializer.cs b/src/DemaConsulting.TestResults/IO/TrxSerializer.cs index d2c2f95..97bdb03 100644 --- a/src/DemaConsulting.TestResults/IO/TrxSerializer.cs +++ b/src/DemaConsulting.TestResults/IO/TrxSerializer.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + using System.Globalization; using System.Text; using System.Xml; diff --git a/src/DemaConsulting.TestResults/TestOutcome.cs b/src/DemaConsulting.TestResults/TestOutcome.cs index 6b486bc..f94eae4 100644 --- a/src/DemaConsulting.TestResults/TestOutcome.cs +++ b/src/DemaConsulting.TestResults/TestOutcome.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + namespace DemaConsulting.TestResults; /// diff --git a/src/DemaConsulting.TestResults/TestResult.cs b/src/DemaConsulting.TestResults/TestResult.cs index e4408f5..b547dcc 100644 --- a/src/DemaConsulting.TestResults/TestResult.cs +++ b/src/DemaConsulting.TestResults/TestResult.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + namespace DemaConsulting.TestResults; /// diff --git a/src/DemaConsulting.TestResults/TestResults.cs b/src/DemaConsulting.TestResults/TestResults.cs index 63364f0..ef57715 100644 --- a/src/DemaConsulting.TestResults/TestResults.cs +++ b/src/DemaConsulting.TestResults/TestResults.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + namespace DemaConsulting.TestResults; /// diff --git a/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs b/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs index e6b2ffe..23259d6 100644 --- a/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs +++ b/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + using Microsoft.VisualStudio.TestTools.UnitTesting; [assembly: Parallelize(Workers = 0, Scope = ExecutionScope.MethodLevel)] diff --git a/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs b/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs index 75018bb..c913ee0 100644 --- a/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs +++ b/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + using DemaConsulting.TestResults.IO; using Microsoft.VisualStudio.TestTools.UnitTesting; diff --git a/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs b/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs index 1b6ab16..4ad1d31 100644 --- a/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs +++ b/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + using System.Xml; using System.Xml.Linq; using System.Xml.XPath; diff --git a/test/DemaConsulting.TestResults.Tests/TestHelpers.cs b/test/DemaConsulting.TestResults.Tests/TestHelpers.cs index 9b2e6a0..d6d23c4 100644 --- a/test/DemaConsulting.TestResults.Tests/TestHelpers.cs +++ b/test/DemaConsulting.TestResults.Tests/TestHelpers.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + namespace DemaConsulting.TestResults.Tests; /// diff --git a/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs b/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs index fbb9d8a..551dbca 100644 --- a/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs +++ b/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs @@ -18,6 +18,8 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. +#nullable enable + using Microsoft.VisualStudio.TestTools.UnitTesting; namespace DemaConsulting.TestResults.Tests; From c51b47f8cee32511091538213539a29f0ab09087 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 11 Dec 2025 20:06:53 +0000 Subject: [PATCH 3/4] Revert explicit #nullable enable directives - keep project-level setting Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> --- src/DemaConsulting.TestResults/IO/TrxSerializer.cs | 2 -- src/DemaConsulting.TestResults/TestOutcome.cs | 2 -- src/DemaConsulting.TestResults/TestResult.cs | 2 -- src/DemaConsulting.TestResults/TestResults.cs | 2 -- test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs | 2 -- test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs | 2 -- test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs | 2 -- test/DemaConsulting.TestResults.Tests/TestHelpers.cs | 2 -- test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs | 2 -- 9 files changed, 18 deletions(-) diff --git a/src/DemaConsulting.TestResults/IO/TrxSerializer.cs b/src/DemaConsulting.TestResults/IO/TrxSerializer.cs index 97bdb03..d2c2f95 100644 --- a/src/DemaConsulting.TestResults/IO/TrxSerializer.cs +++ b/src/DemaConsulting.TestResults/IO/TrxSerializer.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - using System.Globalization; using System.Text; using System.Xml; diff --git a/src/DemaConsulting.TestResults/TestOutcome.cs b/src/DemaConsulting.TestResults/TestOutcome.cs index f94eae4..6b486bc 100644 --- a/src/DemaConsulting.TestResults/TestOutcome.cs +++ b/src/DemaConsulting.TestResults/TestOutcome.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - namespace DemaConsulting.TestResults; /// diff --git a/src/DemaConsulting.TestResults/TestResult.cs b/src/DemaConsulting.TestResults/TestResult.cs index b547dcc..e4408f5 100644 --- a/src/DemaConsulting.TestResults/TestResult.cs +++ b/src/DemaConsulting.TestResults/TestResult.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - namespace DemaConsulting.TestResults; /// diff --git a/src/DemaConsulting.TestResults/TestResults.cs b/src/DemaConsulting.TestResults/TestResults.cs index ef57715..63364f0 100644 --- a/src/DemaConsulting.TestResults/TestResults.cs +++ b/src/DemaConsulting.TestResults/TestResults.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - namespace DemaConsulting.TestResults; /// diff --git a/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs b/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs index 23259d6..e6b2ffe 100644 --- a/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs +++ b/test/DemaConsulting.TestResults.Tests/AssemblyInfo.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - using Microsoft.VisualStudio.TestTools.UnitTesting; [assembly: Parallelize(Workers = 0, Scope = ExecutionScope.MethodLevel)] diff --git a/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs b/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs index c913ee0..75018bb 100644 --- a/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs +++ b/test/DemaConsulting.TestResults.Tests/IO/TrxExampleTests.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - using DemaConsulting.TestResults.IO; using Microsoft.VisualStudio.TestTools.UnitTesting; diff --git a/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs b/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs index 4ad1d31..1b6ab16 100644 --- a/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs +++ b/test/DemaConsulting.TestResults.Tests/IO/TrxSerializerTests.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - using System.Xml; using System.Xml.Linq; using System.Xml.XPath; diff --git a/test/DemaConsulting.TestResults.Tests/TestHelpers.cs b/test/DemaConsulting.TestResults.Tests/TestHelpers.cs index d6d23c4..9b2e6a0 100644 --- a/test/DemaConsulting.TestResults.Tests/TestHelpers.cs +++ b/test/DemaConsulting.TestResults.Tests/TestHelpers.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - namespace DemaConsulting.TestResults.Tests; /// diff --git a/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs b/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs index 551dbca..fbb9d8a 100644 --- a/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs +++ b/test/DemaConsulting.TestResults.Tests/TestOutcomeTests.cs @@ -18,8 +18,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE // SOFTWARE. -#nullable enable - using Microsoft.VisualStudio.TestTools.UnitTesting; namespace DemaConsulting.TestResults.Tests; From 7978ffb3f6e7c26859c2dd88401c680d75ecdf47 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 11 Dec 2025 20:55:13 +0000 Subject: [PATCH 4/4] Update AGENTS.md to clarify project-level nullable configuration Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> --- AGENTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index 9f6ae50..da8971f 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -59,7 +59,7 @@ Use these commands to perform common development tasks: ## Code Style and Conventions * Follow standard C# naming conventions (PascalCase for classes/methods/properties, camelCase for local variables). -* Use nullable reference types (`#nullable enable`). +* Nullable reference types are enabled at the project level (`enable` in .csproj files). Do not use file-level `#nullable enable` directives. * Warnings are treated as errors (`true`). * Avoid public fields; prefer properties.