New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly refactor expected data files to be more descriptive #13

Open

MrPowers opened this issue Oct 10, 2022 · 1 comment

Labels

enhancement good first issue

Contributor

MrPowers commented Oct 10, 2022

Here's how the reference tables are currently structured:

out/tables/generated/reference_table_1/
├── delta
│   ├── _delta_log
│   │   ├── 00000000000000000000.json
│   │   └── 00000000000000000001.json
│   ├── part-00000-3411d322-e527-4412-a307-1b7200ee5969-c000.snappy.parquet
│   └── part-00019-b68afb45-87bb-49f2-95e9-45774d154db4-c000.snappy.parquet
├── parquet
│   └── table_content.parquet
└── table-metadata.json

This could be better:

out/tables/generated/reference_table_1/
├── delta
│   ├── _delta_log
│   │   ├── 00000000000000000000.json
│   │   └── 00000000000000000001.json
│   ├── part-00000-3411d322-e527-4412-a307-1b7200ee5969-c000.snappy.parquet
│   └── part-00019-b68afb45-87bb-49f2-95e9-45774d154db4-c000.snappy.parquet
├── expected
│   └── table_content_latest.parquet
│   └── table_metadata_latest.json

This structure would also allow us to add files like table_content_v1.parquet, that'd allow us to make time travel reader tests as suggested in #8.

The text was updated successfully, but these errors were encountered:

MrPowers added enhancement good first issue labels

Contributor

edmondop commented Oct 22, 2022

💯 great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment