Skip to content

Commit e8e8dd6

Browse files
Christoph Hellwigbjorn-helgaas
authored andcommitted
[media] cobalt: use pci_irq_allocate_vectors()
Simplify the interrupt setup by using the new PCI layer helpers. Despite using pci_enable_msi_range(), this driver was only requesting a single MSI vector anyway. Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent dadf173 commit e8e8dd6

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

drivers/media/pci/cobalt/cobalt-driver.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -308,9 +308,7 @@ static void cobalt_pci_iounmap(struct cobalt *cobalt, struct pci_dev *pci_dev)
308308
static void cobalt_free_msi(struct cobalt *cobalt, struct pci_dev *pci_dev)
309309
{
310310
free_irq(pci_dev->irq, (void *)cobalt);
311-
312-
if (cobalt->msi_enabled)
313-
pci_disable_msi(pci_dev);
311+
pci_free_irq_vectors(pci_dev);
314312
}
315313

316314
static int cobalt_setup_pci(struct cobalt *cobalt, struct pci_dev *pci_dev,
@@ -387,14 +385,12 @@ static int cobalt_setup_pci(struct cobalt *cobalt, struct pci_dev *pci_dev,
387385
from being generated. */
388386
cobalt_set_interrupt(cobalt, false);
389387

390-
if (pci_enable_msi_range(pci_dev, 1, 1) < 1) {
388+
if (pci_alloc_irq_vectors(pci_dev, 1, 1, PCI_IRQ_MSI) < 1) {
391389
cobalt_err("Could not enable MSI\n");
392-
cobalt->msi_enabled = false;
393390
ret = -EIO;
394391
goto err_release;
395392
}
396393
msi_config_show(cobalt, pci_dev);
397-
cobalt->msi_enabled = true;
398394

399395
/* Register IRQ */
400396
if (request_irq(pci_dev->irq, cobalt_irq_handler, IRQF_SHARED,

drivers/media/pci/cobalt/cobalt-driver.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,6 @@ struct cobalt {
287287
u32 irq_none;
288288
u32 irq_full_fifo;
289289

290-
bool msi_enabled;
291-
292290
/* omnitek dma */
293291
int dma_channels;
294292
int first_fifo_channel;

0 commit comments

Comments
 (0)