Skip to content

Commit 816c6be

Browse files
committed
wifi: mac80211: fix BSS_CHANGED_UNSOL_BCAST_PROBE_RESP
Fix the definition of BSS_CHANGED_UNSOL_BCAST_PROBE_RESP so that not all higher bits get set, 1<<31 is a signed variable, so when we do u64 changed = BSS_CHANGED_UNSOL_BCAST_PROBE_RESP; we get sign expansion, so the value is 0xffff'ffff'8000'0000 and that's clearly not desired. Use BIT_ULL() to make it unsigned as well as the right type for the change flags. Fixes: 178e9d6 ("wifi: mac80211: fix unsolicited broadcast probe config") Reviewed-by: Miriam Rachel Korenblit <[email protected]> Link: https://patch.msgid.link/20240627104257.06174d291db2.Iba0d642916eb78a61f8ab2cc5ca9280783d9c1db@changeid Signed-off-by: Johannes Berg <[email protected]>
1 parent c40ff9b commit 816c6be

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/net/mac80211.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ enum ieee80211_bss_change {
395395
BSS_CHANGED_HE_OBSS_PD = 1<<28,
396396
BSS_CHANGED_HE_BSS_COLOR = 1<<29,
397397
BSS_CHANGED_FILS_DISCOVERY = 1<<30,
398-
BSS_CHANGED_UNSOL_BCAST_PROBE_RESP = 1<<31,
398+
BSS_CHANGED_UNSOL_BCAST_PROBE_RESP = BIT_ULL(31),
399399
BSS_CHANGED_MLD_VALID_LINKS = BIT_ULL(33),
400400
BSS_CHANGED_MLD_TTLM = BIT_ULL(34),
401401

0 commit comments

Comments
 (0)