net: amd-xgbe: disable interrupts during pci removal

RajuRangoju · davem330 · commit 68c2d6af1f1e · 2022-02-09T12:52:59.000Z
Hardware interrupts are enabled during the pci probe, however, they are not disabled during pci removal. Disable all hardware interrupts during pci removal to avoid any issues. Fixes: e753774 ("amd-xgbe: Update PCI support to use new IRQ functions") Suggested-by: Selwin Sebastian <Selwin.Sebastian@amd.com> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
@@ -425,6 +425,9 @@ static void xgbe_pci_remove(struct pci_dev *pdev)
 
 	pci_free_irq_vectors(pdata->pcidev);
 
+	/* Disable all interrupts in the hardware */
+	XP_IOWRITE(pdata, XP_INT_EN, 0x0);
+
 	xgbe_free_pdata(pdata);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -425,6 +425,9 @@ static void xgbe_pci_remove(struct pci_dev *pdev)`
`425`	`425`
`426`	`426`	`pci_free_irq_vectors(pdata->pcidev);`
`427`	`427`
	`428`	`+ /* Disable all interrupts in the hardware */`
	`429`	`+ XP_IOWRITE(pdata, XP_INT_EN, 0x0);`
	`430`	`+`
`428`	`431`	`xgbe_free_pdata(pdata);`
`429`	`432`	`}`
`430`	`433`