Skip to content

Commit 1dfd9b5

Browse files
Jozef Hopkosmb49
authored andcommitted
wifi: wilc1000: fix ies_len type in connect path
BugLink: https://bugs.launchpad.net/bugs/2077600 [ Upstream commit 39ab8ff ] Commit 205c503 ("wifi: wilc1000: fix RCU usage in connect path") made sure that the IEs data was manipulated under the relevant RCU section. Unfortunately, while doing so, the commit brought a faulty implicit cast from int to u8 on the ies_len variable, making the parsing fail to be performed correctly if the IEs block is larger than 255 bytes. This failure can be observed with Access Points appending a lot of IEs TLVs in their beacon frames (reproduced with a Pixel phone acting as an Access Point, which brough 273 bytes of IE data in my testing environment). Fix IEs parsing by removing this undesired implicit cast. Fixes: 205c503 ("wifi: wilc1000: fix RCU usage in connect path") Signed-off-by: Jozef Hopko <[email protected]> Signed-off-by: Alexis Lothoré <[email protected]> Acked-by: Ajay Singh <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Sasha Levin <[email protected]> Signed-off-by: Portia Stephens <[email protected]> Signed-off-by: Roxana Nicolescu <[email protected]>
1 parent c25fd7f commit 1dfd9b5

File tree

1 file changed

+2
-1
lines changed
  • drivers/net/wireless/microchip/wilc1000

1 file changed

+2
-1
lines changed

drivers/net/wireless/microchip/wilc1000/hif.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,8 @@ wilc_parse_join_bss_param(struct cfg80211_bss *bss,
382382
struct ieee80211_p2p_noa_attr noa_attr;
383383
const struct cfg80211_bss_ies *ies;
384384
struct wilc_join_bss_param *param;
385-
u8 rates_len = 0, ies_len;
385+
u8 rates_len = 0;
386+
int ies_len;
386387
int ret;
387388

388389
param = kzalloc(sizeof(*param), GFP_KERNEL);

0 commit comments

Comments
 (0)