Skip to content

Commit fb9eb89

Browse files
Mahesh Bandewardavem330
authored andcommitted
bonding: handle link transition from FAIL to UP correctly
When link transitions from LINK_FAIL to LINK_UP, the commit phase is not called. This leads to an erroneous state causing slave-link state to get stuck in "going down" state while its speed and duplex are perfectly fine. This issue is a side-effect of splitting link-set into propose and commit phases introduced by de77ecd ("bonding: improve link-status update in mii-monitoring") This patch fixes these issues by calling commit phase whenever link state change is proposed. Fixes: de77ecd ("bonding: improve link-status update in mii-monitoring") Signed-off-by: Mahesh Bandewar <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent d4d49bc commit fb9eb89

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/bonding/bond_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2064,6 +2064,7 @@ static int bond_miimon_inspect(struct bonding *bond)
20642064
(bond->params.downdelay - slave->delay) *
20652065
bond->params.miimon,
20662066
slave->dev->name);
2067+
commit++;
20672068
continue;
20682069
}
20692070

@@ -2098,7 +2099,7 @@ static int bond_miimon_inspect(struct bonding *bond)
20982099
(bond->params.updelay - slave->delay) *
20992100
bond->params.miimon,
21002101
slave->dev->name);
2101-
2102+
commit++;
21022103
continue;
21032104
}
21042105

0 commit comments

Comments
 (0)