ocfs2: free inode when ocfs2_get_init_inode() fails

BugLink: https://bugs.launchpad.net/bugs/2095283

[ Upstream commit 965b5dd ]

syzbot is reporting busy inodes after unmount, for commit 9c89fe0
("ocfs2: Handle error from dquot_initialize()") forgot to call iput() when
new_inode() succeeded and dquot_initialize() failed.

Link: https://lkml.kernel.org/r/[email protected]
Fixes: 9c89fe0 ("ocfs2: Handle error from dquot_initialize()")
Signed-off-by: Tetsuo Handa <[email protected]>
Reported-by: [email protected]
Closes: https://syzkaller.appspot.com/bug?extid=0af00f6a2cba2058b5db
Tested-by: [email protected]
Reviewed-by: Joseph Qi <[email protected]>
Cc: Mark Fasheh <[email protected]>
Cc: Joel Becker <[email protected]>
Cc: Junxiao Bi <[email protected]>
Cc: Changwei Ge <[email protected]>
Cc: Jun Piao <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
CVE-2024-56630
Signed-off-by: Koichiro Den <[email protected]>

Author: Tetsuo Handa

fs/ocfs2/namei.c

@@ -200,8 +200,10 @@ static struct inode *ocfs2_get_init_inode(struct inode *dir, umode_t mode)
 	mode = mode_strip_sgid(&init_user_ns, dir, mode);
 	inode_init_owner(&init_user_ns, inode, dir, mode);
 	status = dquot_initialize(inode);
-	if (status)
+	if (status) {
+		iput(inode);
 		return ERR_PTR(status);
+	}
 
 	return inode;
 }