Skip to content

Commit ae07485

Browse files
frank-wkuba-moo
authored andcommitted
dt-bindings: net: dsa: make reset optional and add rgmii-mode to mt7531
A board may have no independent reset-line, so reset cannot be used inside switch driver. E.g. on Bananapi-R2 Pro switch and gmac are connected to same reset-line. Resets should be acquired only to 1 device/driver. This prevents reset to be bound to switch-driver if reset is already used for gmac. If reset is only used by switch driver it resets the switch *and* the gmac after the mdio bus comes up resulting in mdio bus goes down. It takes some time until all is up again, switch driver tries to read from mdio, will fail and defer the probe. On next try the reset does the same again. Make reset optional for such boards. Allow port 5 as cpu-port and phy-mode rgmii for mt7531. - MT7530 supports RGMII on port 5 and RGMII/TRGMII on port 6. - MT7531 supports on port 5 RGMII and SGMII (dual-sgmii) and SGMII on port 6. Signed-off-by: Frank Wunderlich <[email protected]> Reviewed-by: Rob Herring <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 1f9a6ab commit ae07485

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ description: |
5555
On mt7531:
5656
- "1000base-x"
5757
- "2500base-x"
58+
- "rgmii"
5859
- "sgmii"
5960
6061
@@ -124,8 +125,8 @@ patternProperties:
124125
properties:
125126
reg:
126127
description:
127-
Port address described must be 6 for CPU port and from 0 to
128-
5 for user ports.
128+
Port address described must be 5 or 6 for CPU port and from 0
129+
to 5 for user ports.
129130

130131
allOf:
131132
- $ref: dsa-port.yaml#
@@ -152,9 +153,6 @@ allOf:
152153
required:
153154
- resets
154155
- reset-names
155-
else:
156-
required:
157-
- reset-gpios
158156

159157
- dependencies:
160158
interrupt-controller: [ interrupts ]

0 commit comments

Comments
 (0)