media: i2c: et8ek8: Don't strip remove function when driver is builtin

Using __exit for the remove function results in the remove callback
being discarded with CONFIG_VIDEO_ET8EK8=y. When such a device gets
unbound (e.g. using sysfs or hotplug), the driver is just removed
without the cleanup being performed. This results in resource leaks. Fix
it by compiling in the remove callback unconditionally.

This also fixes a W=1 modpost warning:

	WARNING: modpost: drivers/media/i2c/et8ek8/et8ek8: section mismatch in reference: et8ek8_i2c_driver+0x10 (section: .data) -> et8ek8_remove (section: .exit.text)

Fixes: c5254e7 ("[media] media: Driver for Toshiba et8ek8 5MP sensor")
Signed-off-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>

CVE-2024-38611
(backported from commit 545b215)
[hui: This backport adjusts context due to 2 conflict, the 1st one is
 the return type of et8ek8_remove(), in J and F, the return type is int
 while in original commit the return type is void, here I kept the
 return type to int; the other one is probe function type, in the J and
 F, it is probe_new, in the original commit, it is probe, here I kept
 probe_new since it is unrelevant to this CVE case.]
Signed-off-by: Hui Wang <[email protected]>
Acked-by: Koichiro Den <[email protected]>
Acked-by: Mehmet Basaran <[email protected]>
Signed-off-by: Stefan Bader <[email protected]>

Author: Uwe Kleine-König

drivers/media/i2c/et8ek8/et8ek8_driver.c

@@ -1460,7 +1460,7 @@ static int et8ek8_probe(struct i2c_client *client)
 	return ret;
 }
 
-static int __exit et8ek8_remove(struct i2c_client *client)
+static int et8ek8_remove(struct i2c_client *client)
 {
 	struct v4l2_subdev *subdev = i2c_get_clientdata(client);
 	struct et8ek8_sensor *sensor = to_et8ek8_sensor(subdev);
@@ -1504,7 +1504,7 @@ static struct i2c_driver et8ek8_i2c_driver = {
 		.of_match_table	= et8ek8_of_table,
 	},
 	.probe_new	= et8ek8_probe,
-	.remove		= __exit_p(et8ek8_remove),
+	.remove		= et8ek8_remove,
 	.id_table	= et8ek8_id_table,
 };