ASoC: tas2781: make const read-only array magic_number static

ColinIanKing · broonie · commit 9a4bf1f0be01 · 2023-10-17T18:39:52.000+01:00
Don't populate the const read-only array magic_number on the stack, instead make it static const. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20231017170436.176615-1-colin.i.king@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
@@ -1757,7 +1757,7 @@ static int fw_parse_header(struct tasdevice_priv *tas_priv,
 {
 	struct tasdevice_dspfw_hdr *fw_hdr = &(tas_fmw->fw_hdr);
 	struct tasdevice_fw_fixed_hdr *fw_fixed_hdr = &(fw_hdr->fixed_hdr);
-	const unsigned char magic_number[] = { 0x35, 0x35, 0x35, 0x32 };
+	static const unsigned char magic_number[] = { 0x35, 0x35, 0x35, 0x32 };
 	const unsigned char *buf = (unsigned char *)fmw->data;
 
 	if (offset + 92 > fmw->size) {

Original file line number	Diff line number	Diff line change
`@@ -1757,7 +1757,7 @@ static int fw_parse_header(struct tasdevice_priv *tas_priv,`
`1757`	`1757`	`{`
`1758`	`1758`	`struct tasdevice_dspfw_hdr *fw_hdr = &(tas_fmw->fw_hdr);`
`1759`	`1759`	`struct tasdevice_fw_fixed_hdr *fw_fixed_hdr = &(fw_hdr->fixed_hdr);`
`1760`		`- const unsigned char magic_number[] = { 0x35, 0x35, 0x35, 0x32 };`
	`1760`	`+ static const unsigned char magic_number[] = { 0x35, 0x35, 0x35, 0x32 };`
`1761`	`1761`	`const unsigned char buf = (unsigned char )fmw->data;`
`1762`	`1762`
`1763`	`1763`	`if (offset + 92 > fmw->size) {`