Skip to content

Commit 6eaeda1

Browse files
Geliang Tangdavem330
authored andcommitted
selftests: mptcp: netlink: drop disable=SC2086
Now there are only a few of variables are not using double quotes. Modifying them, then "shellcheck disable=SC2086" can be dropped. Signed-off-by: Geliang Tang <[email protected]> Reviewed-by: Matthieu Baerts (NGI0) <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0cef6fc commit 6eaeda1

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

tools/testing/selftests/net/mptcp/pm_netlink.sh

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
#!/bin/bash
22
# SPDX-License-Identifier: GPL-2.0
33

4-
# Double quotes to prevent globbing and word splitting is recommended in new
5-
# code but we accept it, especially because there were too many before having
6-
# address all other issues detected by shellcheck.
7-
#shellcheck disable=SC2086
8-
94
. "$(dirname "${0}")/mptcp_lib.sh"
105

116
ret=0
@@ -20,14 +15,14 @@ optstring=hi
2015
while getopts "$optstring" option;do
2116
case "$option" in
2217
"h")
23-
usage $0
18+
usage "$0"
2419
exit ${KSFT_PASS}
2520
;;
2621
"i")
2722
mptcp_lib_set_ip_mptcp
2823
;;
2924
"?")
30-
usage $0
25+
usage "$0"
3126
exit ${KSFT_FAIL}
3227
;;
3328
esac
@@ -40,7 +35,7 @@ err=$(mktemp)
4035
#shellcheck disable=SC2317
4136
cleanup()
4237
{
43-
rm -f $err
38+
rm -f "${err}"
4439
mptcp_lib_ns_exit "${ns1}"
4540
}
4641

0 commit comments

Comments
 (0)