Commit 1a5352a
wifi: ath11k: fix temperature event locking
The ath11k active pdevs are protected by RCU but the temperature event
handling code calling ath11k_mac_get_ar_by_pdev_id() was not marked as a
read-side critical section as reported by RCU lockdep:
=============================
WARNING: suspicious RCU usage
6.6.0-rc6 #7 Not tainted
-----------------------------
drivers/net/wireless/ath/ath11k/mac.c:638 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
no locks held by swapper/0/0.
...
Call trace:
...
lockdep_rcu_suspicious+0x16c/0x22c
ath11k_mac_get_ar_by_pdev_id+0x194/0x1b0 [ath11k]
ath11k_wmi_tlv_op_rx+0xa84/0x2c1c [ath11k]
ath11k_htc_rx_completion_handler+0x388/0x510 [ath11k]
Mark the code in question as an RCU read-side critical section to avoid
any potential use-after-free issues.
Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23
Fixes: a41d103 ("ath11k: add thermal sensor device support")
Cc: [email protected] # 5.7
Signed-off-by: Johan Hovold <[email protected]>
Acked-by: Jeff Johnson <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
Link: https://lore.kernel.org/r/[email protected]1 parent cda8607 commit 1a5352a
1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8382 | 8382 | | |
8383 | 8383 | | |
8384 | 8384 | | |
| 8385 | + | |
| 8386 | + | |
8385 | 8387 | | |
8386 | 8388 | | |
8387 | 8389 | | |
8388 | | - | |
8389 | | - | |
| 8390 | + | |
8390 | 8391 | | |
8391 | 8392 | | |
8392 | 8393 | | |
8393 | 8394 | | |
| 8395 | + | |
| 8396 | + | |
| 8397 | + | |
8394 | 8398 | | |
8395 | 8399 | | |
8396 | 8400 | | |
| |||
0 commit comments