Skip to content

Commit f46ac00

Browse files
larsclausenjic23
authored andcommitted
iio: dac: Convert powerdown read callbacks to sysfs_emit()
Update DAC drivers powerdown attribute show callback to use the new sysfs_emit() function. sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it knows about the sysfs buffer specifics and has some built-in sanity checks. Signed-off-by: Lars-Peter Clausen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 6b92ba0 commit f46ac00

File tree

19 files changed

+23
-23
lines changed

19 files changed

+23
-23
lines changed

drivers/iio/dac/ad5064.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ static ssize_t ad5064_read_dac_powerdown(struct iio_dev *indio_dev,
277277
{
278278
struct ad5064_state *st = iio_priv(indio_dev);
279279

280-
return sprintf(buf, "%d\n", st->pwr_down[chan->channel]);
280+
return sysfs_emit(buf, "%d\n", st->pwr_down[chan->channel]);
281281
}
282282

283283
static ssize_t ad5064_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5360.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ static ssize_t ad5360_read_dac_powerdown(struct device *dev,
255255
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
256256
struct ad5360_state *st = iio_priv(indio_dev);
257257

258-
return sprintf(buf, "%d\n", (bool)(st->ctrl & AD5360_SF_CTRL_PWR_DOWN));
258+
return sysfs_emit(buf, "%d\n", (bool)(st->ctrl & AD5360_SF_CTRL_PWR_DOWN));
259259
}
260260

261261
static int ad5360_update_ctrl(struct iio_dev *indio_dev, unsigned int set,

drivers/iio/dac/ad5380.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ static ssize_t ad5380_read_dac_powerdown(struct iio_dev *indio_dev,
8585
{
8686
struct ad5380_state *st = iio_priv(indio_dev);
8787

88-
return sprintf(buf, "%d\n", st->pwr_down);
88+
return sysfs_emit(buf, "%d\n", st->pwr_down);
8989
}
9090

9191
static ssize_t ad5380_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5446.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ static ssize_t ad5446_read_dac_powerdown(struct iio_dev *indio_dev,
100100
{
101101
struct ad5446_state *st = iio_priv(indio_dev);
102102

103-
return sprintf(buf, "%d\n", st->pwr_down);
103+
return sysfs_emit(buf, "%d\n", st->pwr_down);
104104
}
105105

106106
static ssize_t ad5446_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5504.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ static ssize_t ad5504_read_dac_powerdown(struct iio_dev *indio_dev,
170170
{
171171
struct ad5504_state *st = iio_priv(indio_dev);
172172

173-
return sprintf(buf, "%d\n",
174-
!(st->pwr_down_mask & (1 << chan->channel)));
173+
return sysfs_emit(buf, "%d\n",
174+
!(st->pwr_down_mask & (1 << chan->channel)));
175175
}
176176

177177
static ssize_t ad5504_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5624r_spi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ static ssize_t ad5624r_read_dac_powerdown(struct iio_dev *indio_dev,
117117
{
118118
struct ad5624r_state *st = iio_priv(indio_dev);
119119

120-
return sprintf(buf, "%d\n",
121-
!!(st->pwr_down_mask & (1 << chan->channel)));
120+
return sysfs_emit(buf, "%d\n",
121+
!!(st->pwr_down_mask & (1 << chan->channel)));
122122
}
123123

124124
static ssize_t ad5624r_write_dac_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5686.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ static ssize_t ad5686_read_dac_powerdown(struct iio_dev *indio_dev,
5757
{
5858
struct ad5686_state *st = iio_priv(indio_dev);
5959

60-
return sprintf(buf, "%d\n", !!(st->pwr_down_mask &
60+
return sysfs_emit(buf, "%d\n", !!(st->pwr_down_mask &
6161
(0x3 << (chan->channel * 2))));
6262
}
6363

drivers/iio/dac/ad5755.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,8 +399,8 @@ static ssize_t ad5755_read_powerdown(struct iio_dev *indio_dev, uintptr_t priv,
399399
{
400400
struct ad5755_state *st = iio_priv(indio_dev);
401401

402-
return sprintf(buf, "%d\n",
403-
(bool)(st->pwr_down & (1 << chan->channel)));
402+
return sysfs_emit(buf, "%d\n",
403+
(bool)(st->pwr_down & (1 << chan->channel)));
404404
}
405405

406406
static ssize_t ad5755_write_powerdown(struct iio_dev *indio_dev, uintptr_t priv,

drivers/iio/dac/ad5758.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ static ssize_t ad5758_read_powerdown(struct iio_dev *indio_dev,
574574
{
575575
struct ad5758_state *st = iio_priv(indio_dev);
576576

577-
return sprintf(buf, "%d\n", st->pwr_down);
577+
return sysfs_emit(buf, "%d\n", st->pwr_down);
578578
}
579579

580580
static ssize_t ad5758_write_powerdown(struct iio_dev *indio_dev,

drivers/iio/dac/ad5770r.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ static ssize_t ad5770r_read_dac_powerdown(struct iio_dev *indio_dev,
433433
{
434434
struct ad5770r_state *st = iio_priv(indio_dev);
435435

436-
return sprintf(buf, "%d\n", st->ch_pwr_down[chan->channel]);
436+
return sysfs_emit(buf, "%d\n", st->ch_pwr_down[chan->channel]);
437437
}
438438

439439
static ssize_t ad5770r_write_dac_powerdown(struct iio_dev *indio_dev,

0 commit comments

Comments
 (0)