Skip to content

Commit dc1fad2

Browse files
committed
Merge series "ASoC: Intel: machine driver updates for 5.16" from Pierre-Louis Bossart <[email protected]>:
One quirk for a Dell TigerLake/SoundWire device, and initial support for platforms based on the ES8336 codec (aka ES8316). For full functionality, an update of the codec driver will be needed. Pierre-Louis Bossart (5): ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec ASoC: Intel: add machine driver for SOF+ES8336 ASoC: Intel: soc-acpi: add missing quirk for TGL SDCA single amp ASoC: Intel: sof_sdw: add missing quirk for Dell SKU 0A45 sound/hda/intel-dsp-config.c | 22 +- sound/soc/intel/boards/Kconfig | 14 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/sof_es8336.c | 569 ++++++++++++++++++ sound/soc/intel/boards/sof_sdw.c | 10 + .../intel/common/soc-acpi-intel-bxt-match.c | 6 + .../intel/common/soc-acpi-intel-glk-match.c | 7 +- .../intel/common/soc-acpi-intel-tgl-match.c | 47 ++ 8 files changed, 674 insertions(+), 3 deletions(-) create mode 100644 sound/soc/intel/boards/sof_es8336.c -- 2.25.1
2 parents 6d0c1f7 + 64ba6d2 commit dc1fad2

File tree

8 files changed

+674
-3
lines changed

8 files changed

+674
-3
lines changed

sound/hda/intel-dsp-config.c

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ struct config_entry {
3131
u16 device;
3232
u8 acpi_hid[ACPI_ID_LEN];
3333
const struct dmi_system_id *dmi_table;
34+
u8 codec_hid[ACPI_ID_LEN];
3435
};
3536

3637
/*
@@ -56,7 +57,7 @@ static const struct config_entry config_table[] = {
5657
/*
5758
* Apollolake (Broxton-P)
5859
* the legacy HDAudio driver is used except on Up Squared (SOF) and
59-
* Chromebooks (SST)
60+
* Chromebooks (SST), as well as devices based on the ES8336 codec
6061
*/
6162
#if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
6263
{
@@ -73,6 +74,11 @@ static const struct config_entry config_table[] = {
7374
{}
7475
}
7576
},
77+
{
78+
.flags = FLAG_SOF,
79+
.device = 0x5a98,
80+
.codec_hid = "ESSX8336",
81+
},
7682
#endif
7783
#if IS_ENABLED(CONFIG_SND_SOC_INTEL_APL)
7884
{
@@ -137,7 +143,7 @@ static const struct config_entry config_table[] = {
137143

138144
/*
139145
* Geminilake uses legacy HDAudio driver except for Google
140-
* Chromebooks
146+
* Chromebooks and devices based on the ES8336 codec
141147
*/
142148
/* Geminilake */
143149
#if IS_ENABLED(CONFIG_SND_SOC_SOF_GEMINILAKE)
@@ -154,6 +160,11 @@ static const struct config_entry config_table[] = {
154160
{}
155161
}
156162
},
163+
{
164+
.flags = FLAG_SOF,
165+
.device = 0x3198,
166+
.codec_hid = "ESSX8336",
167+
},
157168
#endif
158169

159170
/*
@@ -311,6 +322,11 @@ static const struct config_entry config_table[] = {
311322
.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
312323
.device = 0x43c8,
313324
},
325+
{
326+
.flags = FLAG_SOF,
327+
.device = 0xa0c8,
328+
.codec_hid = "ESSX8336",
329+
},
314330
#endif
315331

316332
/* Elkhart Lake */
@@ -354,6 +370,8 @@ static const struct config_entry *snd_intel_dsp_find_config
354370
continue;
355371
if (table->dmi_table && !dmi_check_system(table->dmi_table))
356372
continue;
373+
if (table->codec_hid[0] && !acpi_dev_present(table->codec_hid, NULL, -1))
374+
continue;
357375
return table;
358376
}
359377
return NULL;

sound/soc/intel/boards/Kconfig

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,20 @@ config SND_SOC_INTEL_SOF_PCM512x_MACH
512512
Say Y or m if you have such a device.
513513
If unsure select "N".
514514

515+
config SND_SOC_INTEL_SOF_ES8336_MACH
516+
tristate "SOF with ES8336 codec in I2S mode"
517+
depends on I2C && ACPI && GPIOLIB
518+
depends on MFD_INTEL_LPSS || COMPILE_TEST
519+
depends on SND_HDA_CODEC_HDMI && SND_SOC_SOF_HDA_AUDIO_CODEC
520+
select SND_SOC_ES8316
521+
select SND_SOC_DMIC
522+
select SND_SOC_INTEL_HDA_DSP_COMMON
523+
help
524+
This adds support for ASoC machine driver for SOF platforms
525+
with es8336 codec.
526+
Say Y if you have such a device.
527+
If unsure select "N".
528+
515529
endif ## SND_SOC_SOF_HDA_LINK || SND_SOC_SOF_BAYTRAIL
516530

517531
if (SND_SOC_SOF_COMETLAKE && SND_SOC_SOF_HDA_LINK)

sound/soc/intel/boards/Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ snd-soc-sst-byt-cht-es8316-objs := bytcht_es8316.o
2121
snd-soc-sst-byt-cht-nocodec-objs := bytcht_nocodec.o
2222
snd-soc-sof_rt5682-objs := sof_rt5682.o sof_realtek_common.o
2323
snd-soc-sof_cs42l42-objs := sof_cs42l42.o
24+
snd-soc-sof_es8336-objs := sof_es8336.o
2425
snd-soc-cml_rt1011_rt5682-objs := cml_rt1011_rt5682.o
2526
snd-soc-kbl_da7219_max98357a-objs := kbl_da7219_max98357a.o
2627
snd-soc-kbl_da7219_max98927-objs := kbl_da7219_max98927.o
@@ -42,6 +43,7 @@ snd-soc-sof-sdw-objs += sof_sdw.o \
4243
sof_sdw_dmic.o sof_sdw_hdmi.o
4344
obj-$(CONFIG_SND_SOC_INTEL_SOF_RT5682_MACH) += snd-soc-sof_rt5682.o
4445
obj-$(CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH) += snd-soc-sof_cs42l42.o
46+
obj-$(CONFIG_SND_SOC_INTEL_SOF_ES8336_MACH) += snd-soc-sof_es8336.o
4547
obj-$(CONFIG_SND_SOC_INTEL_HASWELL_MACH) += snd-soc-sst-haswell.o
4648
obj-$(CONFIG_SND_SOC_INTEL_BXT_DA7219_MAX98357A_COMMON) += snd-soc-sst-bxt-da7219_max98357a.o
4749
obj-$(CONFIG_SND_SOC_INTEL_BXT_RT298_MACH) += snd-soc-sst-bxt-rt298.o

0 commit comments

Comments
 (0)