Skip to content

Commit 12f63a2

Browse files
amir73ilnukelet
authored andcommitted
cifs: fix set of group SID via NTSD xattrs
BugLink: https://bugs.launchpad.net/bugs/2036450 'setcifsacl -g <SID>' silently fails to set the group SID on server. Actually, the bug existed since commit 438471b ("CIFS: Add support for setting owner info, dos attributes, and create time"), but this fix will not apply cleanly to kernel versions <= v5.10. Fixes: 3970acf ("SMB3: Add support for getting and setting SACLs") Cc: [email protected] # 5.11+ Signed-off-by: Amir Goldstein <[email protected]> Signed-off-by: Steve French <[email protected]> (cherry picked from commit dd5a927) Signed-off-by: Tim Gardner <[email protected]>
1 parent ae997dc commit 12f63a2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

fs/cifs/xattr.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,13 @@ static int cifs_xattr_set(const struct xattr_handler *handler,
178178
switch (handler->flags) {
179179
case XATTR_CIFS_NTSD_FULL:
180180
aclflags = (CIFS_ACL_OWNER |
181+
CIFS_ACL_GROUP |
181182
CIFS_ACL_DACL |
182183
CIFS_ACL_SACL);
183184
break;
184185
case XATTR_CIFS_NTSD:
185186
aclflags = (CIFS_ACL_OWNER |
187+
CIFS_ACL_GROUP |
186188
CIFS_ACL_DACL);
187189
break;
188190
case XATTR_CIFS_ACL:

0 commit comments

Comments
 (0)