Skip to content

Commit 988b7a4

Browse files
andraprsgregkh
authored andcommitted
nitro_enclaves: Add logic for getting the enclave image load info
Before setting the memory regions for the enclave, the enclave image needs to be placed in memory. After the memory regions are set, this memory cannot be used anymore by the VM, being carved out. Add ioctl command logic to get the offset in enclave memory where to place the enclave image. Then the user space tooling copies the enclave image in the memory using the given memory offset. Changelog v9 -> v10 * Update commit message to include the changelog before the SoB tag(s). v8 -> v9 * No changes. v7 -> v8 * Add custom error code for incorrect enclave image load info flag. v6 -> v7 * No changes. v5 -> v6 * Check for invalid enclave image load flags. v4 -> v5 * Check for the enclave not being started when invoking this ioctl call. * Remove log on copy_from_user() / copy_to_user() failure. v3 -> v4 * Use dev_err instead of custom NE log pattern. * Set enclave image load offset based on flags. * Update the naming for the ioctl command from metadata to info. v2 -> v3 * No changes. v1 -> v2 * New in v2. Reviewed-by: Alexander Graf <[email protected]> Signed-off-by: Andra Paraschiv <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent ff8a4d3 commit 988b7a4

File tree

1 file changed

+36
-0
lines changed

1 file changed

+36
-0
lines changed

drivers/virt/nitro_enclaves/ne_misc_dev.c

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -807,6 +807,42 @@ static long ne_enclave_ioctl(struct file *file, unsigned int cmd, unsigned long
807807
return 0;
808808
}
809809

810+
case NE_GET_IMAGE_LOAD_INFO: {
811+
struct ne_image_load_info image_load_info = {};
812+
813+
if (copy_from_user(&image_load_info, (void __user *)arg, sizeof(image_load_info)))
814+
return -EFAULT;
815+
816+
mutex_lock(&ne_enclave->enclave_info_mutex);
817+
818+
if (ne_enclave->state != NE_STATE_INIT) {
819+
dev_err_ratelimited(ne_misc_dev.this_device,
820+
"Enclave is not in init state\n");
821+
822+
mutex_unlock(&ne_enclave->enclave_info_mutex);
823+
824+
return -NE_ERR_NOT_IN_INIT_STATE;
825+
}
826+
827+
mutex_unlock(&ne_enclave->enclave_info_mutex);
828+
829+
if (!image_load_info.flags ||
830+
image_load_info.flags >= NE_IMAGE_LOAD_MAX_FLAG_VAL) {
831+
dev_err_ratelimited(ne_misc_dev.this_device,
832+
"Incorrect flag in enclave image load info\n");
833+
834+
return -NE_ERR_INVALID_FLAG_VALUE;
835+
}
836+
837+
if (image_load_info.flags == NE_EIF_IMAGE)
838+
image_load_info.memory_offset = NE_EIF_LOAD_OFFSET;
839+
840+
if (copy_to_user((void __user *)arg, &image_load_info, sizeof(image_load_info)))
841+
return -EFAULT;
842+
843+
return 0;
844+
}
845+
810846
default:
811847
return -ENOTTY;
812848
}

0 commit comments

Comments
 (0)