nvme-tcp: block BH in sk state_change sk callback

sagigrimberg · Christoph Hellwig · commit 8b73b45d54a1 · 2021-04-02T18:48:28.000+02:00
The TCP stack can run from process context for a long time so we should disable BH here. Fixes: 3f2304f ("nvme-tcp: add NVMe over TCP host driver") Signed-off-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
@@ -870,7 +870,7 @@ static void nvme_tcp_state_change(struct sock *sk)
 {
 	struct nvme_tcp_queue *queue;
 
-	read_lock(&sk->sk_callback_lock);
+	read_lock_bh(&sk->sk_callback_lock);
 	queue = sk->sk_user_data;
 	if (!queue)
 		goto done;
@@ -891,7 +891,7 @@ static void nvme_tcp_state_change(struct sock *sk)
 
 	queue->state_change(sk);
 done:
-	read_unlock(&sk->sk_callback_lock);
+	read_unlock_bh(&sk->sk_callback_lock);
 }
 
 static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)

Original file line number	Diff line number	Diff line change
`@@ -870,7 +870,7 @@ static void nvme_tcp_state_change(struct sock *sk)`
`870`	`870`	`{`
`871`	`871`	`struct nvme_tcp_queue *queue;`
`872`	`872`
`873`		`- read_lock(&sk->sk_callback_lock);`
	`873`	`+ read_lock_bh(&sk->sk_callback_lock);`
`874`	`874`	`queue = sk->sk_user_data;`
`875`	`875`	`if (!queue)`
`876`	`876`	`goto done;`
`@@ -891,7 +891,7 @@ static void nvme_tcp_state_change(struct sock *sk)`
`891`	`891`
`892`	`892`	`queue->state_change(sk);`
`893`	`893`	`done:`
`894`		`- read_unlock(&sk->sk_callback_lock);`
	`894`	`+ read_unlock_bh(&sk->sk_callback_lock);`
`895`	`895`	`}`
`896`	`896`
`897`	`897`	`static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)`