Translate tests/test_lexer.py to C unit test

To try out our new testing framework, move some simple Python unit tests
for the internal lexer API to C unit tests.

Signed-off-by: Omar Sandoval <[email protected]>

Author: osandov

libdrgn/Makefile.am

@@ -214,7 +214,7 @@ examples_load_debug_info_LDADD = libdrgnimpl.la
 # Python unit tests instead.
 TESTS = $(check_PROGRAMS)
 
-check_PROGRAMS =
+check_PROGRAMS = tests/lexer
 
 EXTRA_DIST += $(addsuffix .c.in,$(check_PROGRAMS))
 
@@ -230,5 +230,9 @@ test_cflags = $(AM_CFLAGS) $(check_CFLAGS)
 test_cppflags = $(AM_CPPFLAGS) -iquote $(srcdir)/tests
 test_ldadd = $(check_LIBS) libdrgnimpl.la
 
+tests_lexer_CFLAGS = $(test_cflags)
+tests_lexer_CPPFLAGS = $(test_cppflags)
+tests_lexer_LDADD = $(test_ldadd)
+
 # Don't delete test-suite.log on failure.
 .PRECIOUS: $(TEST_SUITE_LOG)

libdrgn/python/test.c

@@ -50,22 +50,6 @@ DRGNPY_PUBLIC struct drgn_error *drgn_test_lexer_peek(struct drgn_lexer *lexer,
 	return drgn_lexer_peek(lexer, token);
 }
 
-struct drgn_error *drgn_test_lexer_func(struct drgn_lexer *lexer,
-					struct drgn_token *token);
-DRGNPY_PUBLIC struct drgn_error *drgn_test_lexer_func(struct drgn_lexer *lexer,
-						      struct drgn_token *token)
-{
-	token->kind = *lexer->p;
-	token->value = lexer->p;
-	if (token->kind) {
-		token->len = 1;
-		lexer->p++;
-	} else {
-		token->len = 0;
-	}
-	return NULL;
-}
-
 typeof(drgn_c_family_lexer_func) drgn_test_lexer_c;
 DRGNPY_PUBLIC struct drgn_error *drgn_test_lexer_c(struct drgn_lexer *lexer,
 						   struct drgn_token *token)

libdrgn/tests/lexer.c.in

@@ -0,0 +1,89 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+// SPDX-License-Identifier: LGPL-2.1-or-later
+
+#include "test_util.h"
+#include "../lexer.h"
+
+static struct drgn_error *dummy_lexer_func(struct drgn_lexer *lexer,
+					   struct drgn_token *token)
+{
+	token->kind = *lexer->p;
+	token->value = lexer->p;
+	if (token->kind) {
+		token->len = 1;
+		lexer->p++;
+	} else {
+		token->len = 0;
+	}
+	return NULL;
+}
+
+#suite lexer
+
+#tcase lexer
+
+#test pop
+{
+	struct drgn_lexer lexer;
+	drgn_lexer_init(&lexer, dummy_lexer_func, "12345");
+	struct drgn_token token;
+	for (int i = 0; i < 5; i++) {
+		drgn_ck_no_err(drgn_lexer_pop(&lexer, &token));
+		ck_assert_int_eq(token.kind, '1' + i);
+		ck_assert_uint_eq(token.len, 1);
+		ck_assert_int_eq(*token.value, '1' + i);
+	}
+	drgn_ck_no_err(drgn_lexer_pop(&lexer, &token));
+	ck_assert_int_eq(token.kind, 0);
+	ck_assert_uint_eq(token.len, 0);
+	drgn_lexer_deinit(&lexer);
+}
+
+#test push
+{
+	struct drgn_lexer lexer;
+	drgn_lexer_init(&lexer, dummy_lexer_func, "12345");
+	struct drgn_token tokens[4];
+	for (int i = 0; i < 4; i++)
+		drgn_ck_no_err(drgn_lexer_pop(&lexer, &tokens[i]));
+	for (int i = 3; i >= 0; i--)
+		drgn_ck_no_err(drgn_lexer_push(&lexer, &tokens[i]));
+	struct drgn_token token;
+	for (int i = 0; i < 5; i++) {
+		drgn_ck_no_err(drgn_lexer_pop(&lexer, &token));
+		ck_assert_int_eq(token.kind, '1' + i);
+		ck_assert_uint_eq(token.len, 1);
+		ck_assert_int_eq(*token.value, '1' + i);
+	}
+	drgn_ck_no_err(drgn_lexer_pop(&lexer, &token));
+	ck_assert_int_eq(token.kind, 0);
+	ck_assert_uint_eq(token.len, 0);
+	drgn_lexer_deinit(&lexer);
+}
+
+#test peek
+{
+	struct drgn_lexer lexer;
+	drgn_lexer_init(&lexer, dummy_lexer_func, "12345");
+	struct drgn_token token;
+	for (int i = 0; i < 5; i++) {
+		drgn_ck_no_err(drgn_lexer_peek(&lexer, &token));
+		ck_assert_int_eq(token.kind, '1' + i);
+		ck_assert_uint_eq(token.len, 1);
+		ck_assert_int_eq(*token.value, '1' + i);
+
+		drgn_ck_no_err(drgn_lexer_pop(&lexer, &token));
+		ck_assert_int_eq(token.kind, '1' + i);
+		ck_assert_uint_eq(token.len, 1);
+		ck_assert_int_eq(*token.value, '1' + i);
+	}
+
+	drgn_ck_no_err(drgn_lexer_peek(&lexer, &token));
+	ck_assert_int_eq(token.kind, 0);
+	ck_assert_uint_eq(token.len, 0);
+
+	drgn_ck_no_err(drgn_lexer_pop(&lexer, &token));
+	ck_assert_int_eq(token.kind, 0);
+	ck_assert_uint_eq(token.len, 0);
+	drgn_lexer_deinit(&lexer);
+}

tests/libdrgn.py

@@ -160,7 +160,6 @@ class _drgn_c_family_lexer(ctypes.Structure):
 
 
 drgn_c_family_lexer_func = drgn_lexer_func.in_dll(_drgn_cdll, "drgn_test_lexer_c")
-drgn_test_lexer_func = drgn_lexer_func.in_dll(_drgn_cdll, "drgn_test_lexer_func")
 
 
 class C_TOKEN(enum.IntEnum):