Check if create, update or noop before publish, plus Rubocop fixes

Author: kplattret

lib/roo_on_rails/routemaster/publisher.rb

@@ -13,7 +13,7 @@ def initialize(model, event, client: ::Routemaster::Client)
       end
 
       def publish?
-        true
+        noop? || @model.new_record? || @model.previous_changes.any?
       end
 
       def will_publish?
@@ -22,7 +22,7 @@ def will_publish?
 
       def publish!
         return unless will_publish?
-        @client.send(event, topic, url, data: stringify_keys(data))
+        @client.send(@event, topic, url, data: stringify_keys(data))
       end
 
       def topic
@@ -37,9 +37,9 @@ def data
         nil
       end
 
-      %i(created updated deleted noop).each do |event_type|
+      %i[created updated deleted noop].each do |event_type|
         define_method :"#{event_type}?" do
-          event.to_sym == event_type
+          @event.to_sym == event_type
         end
       end
 

spec/integration/routemaster_spec.rb

@@ -13,17 +13,17 @@
     end
 
     context 'if ROUTEMASTER_ENABLED is true' do
-      let(:app_env_vars) { ["ROUTEMASTER_ENABLED=true", super()].join("\n") }
+      let(:app_env_vars) { ['ROUTEMASTER_ENABLED=true', super()].join("\n") }
 
       context 'and ROOBUS_URL/ROOBUS_UUID are not set' do
         it 'the app fails to load' do
-          app.wait_log /Exiting/
+          app.wait_log(/Exiting/)
           app.stop
           expect(app.status).not_to be_success
         end
 
         it 'the app logs the failure' do
-          app.wait_log /ROOBUS_URL and ROOBUS_UUID are required/
+          app.wait_log(/ROOBUS_URL and ROOBUS_UUID are required/)
         end
       end
     end

spec/roo_on_rails/routemaster/lifecycle_events_spec.rb

@@ -22,28 +22,30 @@ def self.after_commit(*args)
   let(:subject_instance) { subject.new }
   let(:publisher_spy) { spy('publisher') }
 
-  describe "::publish_lifecycle_events" do
-    context "when called without arguments" do
+  describe '::publish_lifecycle_events' do
+    context 'when called without arguments' do
       before { subject.publish_lifecycle_events }
 
-      it "adds three event hooks" do
+      it 'adds three event hooks' do
         expect(subject.after_commit_hooks).to match_array([
           [:publish_lifecycle_event_on_create, { on: :create }],
           [:publish_lifecycle_event_on_update, { on: :update }],
           [:publish_lifecycle_event_on_destroy, { on: :destroy }]
         ])
       end
 
-      describe "and calling a callback" do
+      describe 'and calling a callback' do
         events_and_types = [
-          %i(create created),
-          %i(update updated),
-          %i(destroy deleted)
+          %i[create created],
+          %i[update updated],
+          %i[destroy deleted]
         ]
 
         events_and_types.each do |lifecycle_event|
           it "fetches a publisher for #{lifecycle_event.first}" do
-            callback = subject.after_commit_hooks.detect { |event| event.last[:on] == lifecycle_event.first }.first
+            callback = subject.after_commit_hooks.detect do |event|
+              event.last[:on] == lifecycle_event.first
+            end.first
 
             allow(RooOnRails::Routemaster::Publishers).to receive(:for).with(subject, lifecycle_event.last) do
               [publisher_spy]
@@ -55,21 +57,23 @@ def self.after_commit(*args)
         end
       end
 
-      it "defines all three lifecycle events and noop on an instance" do
-        expect {
+      it 'defines all three lifecycle events and noop on an instance' do
+        expect do
           subject_instance.method(:publish_lifecycle_event_on_create)
           subject_instance.method(:publish_lifecycle_event_on_update)
           subject_instance.method(:publish_lifecycle_event_on_destroy)
           subject_instance.method(:publish_lifecycle_event_on_noop)
-        }.to_not raise_error
+        end.to_not raise_error
       end
     end
 
     context "when called with a 'create' lifecycle event" do
       before { subject.publish_lifecycle_events(:create) }
 
       it "adds a 'create' hook only" do
-        expect(subject.after_commit_hooks).to match_array([[:publish_lifecycle_event_on_create, { on: :create }]])
+        expect(subject.after_commit_hooks).to match_array([
+          [:publish_lifecycle_event_on_create, { on: :create }]
+        ])
       end
     end
   end

spec/roo_on_rails/routemaster/publisher_spec.rb

@@ -17,30 +17,30 @@
 
     before do
       allow(publisher).to receive_messages(
-        url: "https://deliveroo.test/url",
-        data: { test_key_1: "Test value 1", test_key_2: "Test value 2" }
+        url: 'https://deliveroo.test/url',
+        data: { test_key_1: 'Test value 1', test_key_2: 'Test value 2' }
       )
     end
 
     it 'should publish an event to Routemaster fine' do
       expect(::Routemaster::Client).to receive(:send).with(
         :noop,
-        "test_models",
-        "https://deliveroo.test/url",
-        { data: {
-          "test_key_1" => "Test value 1",
-          "test_key_2" => "Test value 2"
-        }}
+        'test_models',
+        'https://deliveroo.test/url',
+        data: {
+          'test_key_1' => 'Test value 1',
+          'test_key_2' => 'Test value 2'
+        }
       )
       publisher.publish!
     end
 
     it 'should have a topic named after the model class' do
-      expect(publisher.topic).to eq("test_models")
+      expect(publisher.topic).to eq('test_models')
     end
 
     it 'should have the correct URL' do
-      expect(publisher.url).to eq("https://deliveroo.test/url")
+      expect(publisher.url).to eq('https://deliveroo.test/url')
     end
 
     it 'should have the correct event type' do