Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier way to stop processors on failure #192

Open
faolivera opened this issue Jun 7, 2017 · 2 comments
Open

Easier way to stop processors on failure #192

faolivera opened this issue Jun 7, 2017 · 2 comments
Labels
Milestone

Comments

@faolivera
Copy link

It would be useful to be able to stop consuming events from the stream if some persistent problem is detected while processing events (database connection problem for instance) and be able to start consuming events again after certain condition is given.

To do that it is needed to stop a processor when its inner consumer detects an error.
The issue is there is no a direct way to map the failing consumer to the processor that created it, so when an error happens inside an observer there is no an easy way to figure out which processor it is needed to be stopped and recreated

@dehora dehora modified the milestone: 0.8.7 Jun 8, 2017
@dehora dehora modified the milestone: 0.8.7 Jun 19, 2017
@dehora dehora added the feature label Jun 19, 2017
@dehora
Copy link
Owner

dehora commented Jun 27, 2017

This is probably going to need some design, possibly a carrier object that tracks processors and consumers.

In the meantime, there's been some changes to stop behaviour in 0.9.0 along with the option to throw a NonRetryableNakadiException from the observer to kill the consumer pipeline.

@dehora dehora added this to the 0.9.1 milestone Jun 27, 2017
@dehora dehora modified the milestones: 0.9.1, roadmap Aug 1, 2017
@olayinkasf
Copy link

Would it also be reasonable to have a shutdown on the client to cleanly shutdown all processors. IMO at the moment it is still unclear how to approach a proper shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants