We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL.format includes the leading slashes regardless of what the slashes property is set to. The behavior is not present in node's URL package.
const nodeUrl = require("url"); const npmUrl = require("./node_modules/url"); console.log(nodeUrl.format({ hostname: "example.com", slashes: false })); // => example.com (good) console.log(npmUrl.format({ hostname: "example.com", slashes: false })); // => //example.com (bad) console.log(nodeUrl.format({ hostname: "example.com", slashes: true })); // => //example.com console.log(npmUrl.format({ hostname: "example.com", slashes: true })); // => //example.com
I am using: NodeJS 10.16.0 url package 0.11.0
The text was updated successfully, but these errors were encountered:
Thanks, this definitely seems like a bug (altho it's also possible that these examples do the same thing in an older version of node).
Once tests on this repo are sorted out, a PR with a failing test case (with or without a fix) would be appreciated.
Sorry, something went wrong.
See #53 as well; this will be addressed as part of "node catchup".
No branches or pull requests
URL.format includes the leading slashes regardless of what the slashes property is set to. The behavior is not present in node's URL package.
I am using:
NodeJS 10.16.0
url package 0.11.0
The text was updated successfully, but these errors were encountered: