Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request - new config options: enableEvents, enableInternalFunctions #35

Open
devtooligan opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@devtooligan
Copy link

devtooligan commented Feb 12, 2024

This would be more helpful to me if we could disable events and internal functions. These two new config options could be default true to maintain the current default behavior.

The current output is a really tall column of text that mixes events and both internal and external functions and I only care about external functions so it's a bit difficult to triage. And the contract I tried it on was short, would probably be unmanageable if it was much longer.

Anyways, great job on making this!

Very helpful

@devtooligan
Copy link
Author

to be clear, i am including private with internal

@gas1cent
Copy link
Member

Hey @devtooligan, thanks for the feedback! Having more control over the rules being applied totally makes sense, we're currently discussing the best way to achieve this. Most likely, we will add a rules option, something like

[
  { events: 'inheritdoc' },
  { enums: 'off' },
  'errors',
  {
    functions: [
      'external',
      'public',
      { internal: { tags: ['dev'] } }
    ]
  },
]

So one could switch between inheritdoc and natspec, enable/disable validation of certain nodes, such as enums, exclude function types from the check and specify what tags are used for the rest. Feel free to suggest more options if you come across a codebase that would benefit from them.

@gas1cent gas1cent added this to the v1.2.0 milestone Feb 13, 2024
@turtlemoji turtlemoji added the enhancement New feature or request label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants