chore: refactor to skip tests on arm64 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwyles
changed the title
Racer159
approved these changes
Jun 18, 2024
ericwyles
pushed a commit
that referenced
this pull request
Jun 20, 2024
🤖 I have created a release *beep* *boop* --- ## [9.8.1-uds.1](v9.8.1-uds.0...v9.8.1-uds.1) (2024-06-20) ### Features * add wait for MM package CR readiness ([#88](#88)) ([8c18d54](8c18d54)) ### Miscellaneous * add `Made for UDS` badge to Mattermost ([#90](#90)) ([fce7636](fce7636)) * add testing on arm64 architecture using qemu ([#95](#95)) ([ba4e8cc](ba4e8cc)) * add tests before publishing a release and remove arm64 architecture ([#91](#91)) ([c136830](c136830)) * **deps:** update mattermost support dependencies ([#87](#87)) ([c0e0ca9](c0e0ca9)) * **deps:** update mattermost support dependencies ([#94](#94)) ([c4fecda](c4fecda)) * exclude registry1 arm64 architecture from matrix ([#97](#97)) ([7c6199d](7c6199d)) * refactor to skip tests on arm64 ([#96](#96)) ([b337bdb](b337bdb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After doing some more experiments we decided to not run arm64 tests under emulation. We will still build the package but not run tests on it. This PR splits the publish steps up into build/test/publish so that they can be selectively ran based on architecture, skipping the tests on arm64.
Related Issue
Relates to #84
Type of change
Checklist before merging