Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support return_embedding param in DocumentStore's get_document_by_id #3007

Closed
tstadel opened this issue Aug 9, 2022 · 0 comments
Closed

Support return_embedding param in DocumentStore's get_document_by_id #3007

tstadel opened this issue Aug 9, 2022 · 0 comments
Labels
P3 Low priority, leave it in the backlog topic:document_store type:feature New feature or request wontfix This will not be worked on

Comments

@tstadel
Copy link
Member

tstadel commented Aug 9, 2022

Is your feature request related to a problem? Please describe.
BaseDocumentStore's get_all_documents supports return_embedding as method param but get_document_by_id does not. This is inconsistent and a bit confusing.

Describe the solution you'd like
Add return_embedding param to get_doucment_by_id of BaseDocumentStore and all its subclasses.

Describe alternatives you've considered
None

Additional context
Besides API consistency this could be handy if you want to check whether an individual document has (correct) embeddings.
@tstadel tstadel added type:feature New feature or request good first issue Good for newcomers Contributions wanted! Looking for external contributions topic:document_store journey:first steps labels Aug 9, 2022
@tstadel tstadel mentioned this issue Aug 9, 2022
Merged
6 tasks
@camillepradel camillepradel mentioned this issue Aug 25, 2022
Closed
6 tasks
@sjrl sjrl added the P3 Low priority, leave it in the backlog label Jan 30, 2023
@masci masci removed the good first issue Good for newcomers label Sep 13, 2023
@masci masci removed the Contributions wanted! Looking for external contributions label Dec 13, 2023
@masci masci added the wontfix This will not be worked on label May 25, 2024
@masci masci closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Low priority, leave it in the backlog topic:document_store type:feature New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
3 participants
@masci @sjrl @tstadel