Skip to content

Two typos on page 16 of the report #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kiankyars opened this issue Jan 20, 2025 · 5 comments · May be fixed by #44
Closed

Two typos on page 16 of the report #5

kiankyars opened this issue Jan 20, 2025 · 5 comments · May be fixed by #44
Labels
closed-as-stale stale

Comments

@kiankyars
Copy link

Great paper, "Conclusion, Limitation, and Future Work" section header is better as:
"Conclusion, Limitations, and Future Work"

"to generate 800K data" on the same page can be improved to "to generate 800K data samples"
@kiankyars
Copy link
Author

on the same page, we have "reject sampling" too, instead of "rejection sampling"

@kiankyars
Copy link
Author

reinforcement learning (RL) is mentioned eight times, seems unnecessary to include the full name each time

@kiankyars
Copy link
Author

"parapraphs" on page 10

jasonkneen referenced this issue in jasonkneen/DeepSeek-R1 Jan 22, 2025
@jasonkneen
Fix typos and improve wording in README.md
4bfb90c 
Fixes #5

Correct typos and improve phrasing in `README.md`.

* Change "reinforcement learning (RL)" to "RL" after the first mention.
* Change "to generate 800K data" to "to generate 800K data samples".
* Change "reject sampling" to "rejection sampling".
* Correct the section header to "Conclusion, Limitations, and Future Work".
* Correct the typo "parapraphs" to "paragraphs".

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/deepseek-ai/DeepSeek-R1/issues/5?shareId=XXXX-XXXX-XXXX-XXXX).
@jasonkneen jasonkneen mentioned this issue Jan 22, 2025
Open
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this issue is still relevant, please leave a comment to keep it open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 21, 2025
@github-actions GitHub Actions
Copy link

false

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-as-stale stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typos and improve wording in README.md jasonkneen/DeepSeek-R1
1 participant
@kiankyars