From 14a4c9f8c7bc7009b1100fff136190dea3dad3e9 Mon Sep 17 00:00:00 2001 From: marcus-sa Date: Thu, 7 Mar 2024 13:52:52 +0100 Subject: [PATCH 1/2] feat(injector): improve set method api --- packages/injector/src/injector.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/injector/src/injector.ts b/packages/injector/src/injector.ts index bcf724267..16bf9e41c 100644 --- a/packages/injector/src/injector.ts +++ b/packages/injector/src/injector.ts @@ -251,7 +251,7 @@ export class Injector implements InjectorInterface { throw new Error(`Invalid get argument given ${token}`); } - set(token: T, value: any, scope?: Scope): void { + set(token: ContainerToken, value: any, scope?: Scope): void { if (!this.setter) throw new Error('Injector was not built'); this.setter(token, value, scope); } @@ -914,7 +914,7 @@ export class InjectorContext { return this.getInjector(module || this.rootModule).instantiationCount(token, this.scope ? this.scope.name : scope); } - set(token: T, value: any, module?: InjectorModule): void { + set(token: ContainerToken, value: any, module?: InjectorModule): void { return this.getInjector(module || this.rootModule).set(token, value, this.scope); } From 901bd2489344c79240ca37421512e5cb0f5f3edc Mon Sep 17 00:00:00 2001 From: marcus-sa Date: Thu, 7 Mar 2024 14:09:20 +0100 Subject: [PATCH 2/2] feat(injector): improve injector context set method api --- packages/injector/src/injector.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/injector/src/injector.ts b/packages/injector/src/injector.ts index 16bf9e41c..bea096862 100644 --- a/packages/injector/src/injector.ts +++ b/packages/injector/src/injector.ts @@ -914,8 +914,12 @@ export class InjectorContext { return this.getInjector(module || this.rootModule).instantiationCount(token, this.scope ? this.scope.name : scope); } - set(token: ContainerToken, value: any, module?: InjectorModule): void { - return this.getInjector(module || this.rootModule).set(token, value, this.scope); + set(token: T, value: any, module?: InjectorModule): void { + return this.getInjector(module || this.rootModule).set( + getContainerToken(token), + value, + this.scope, + ); } static forProviders(providers: ProviderWithScope[]) {