From ca39a7f74df9281607158bd5dfe1eab9dd808a73 Mon Sep 17 00:00:00 2001 From: cofri Date: Wed, 8 Jun 2022 12:49:02 +0200 Subject: [PATCH 1/3] chore: update versions of pre-commit hooks Note that black hook was broken, requiring the update for this hook. In the meantime, other hooks were updated too. Moreover, some other files did not pass the "trailing spaces" hook. They were fixed. --- .github/ISSUE_TEMPLATE/generic_bug_report.yaml | 2 +- .pre-commit-config.yaml | 12 ++++++------ CONTRIBUTING.md | 2 +- GOVERNANCE.md | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/generic_bug_report.yaml b/.github/ISSUE_TEMPLATE/generic_bug_report.yaml index a0b1132..137fe4c 100644 --- a/.github/ISSUE_TEMPLATE/generic_bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/generic_bug_report.yaml @@ -16,7 +16,7 @@ body: options: - Layers - Activation functions - - Initializers + - Initializers - Loss functions - Normalizers validations: diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index d2de5a1..53318b0 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -19,7 +19,7 @@ repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.0.1 + rev: v4.3.0 hooks: - id: trailing-whitespace - id: end-of-file-fixer @@ -27,30 +27,30 @@ repos: - id: check-added-large-files - repo: https://github.com/asottile/reorder_python_imports - rev: v2.6.0 + rev: v3.1.0 hooks: - id: reorder-python-imports - repo: https://github.com/psf/black - rev: 21.6b0 + rev: 22.3.0 hooks: - id: black - repo: https://github.com/pre-commit/mirrors-pylint - rev: v3.0.0a3 + rev: v3.0.0a5 hooks: - id: pylint args: [--enable=unused-import --max-line-length=100, --disable=all] - repo: https://github.com/commitizen-tools/commitizen - rev: v2.20.0 + rev: v2.27.1 hooks: - id: commitizen stages: [commit-msg] - repo: https://github.com/Lucas-C/pre-commit-hooks - rev: v1.1.10 + rev: v1.2.0 hooks: - id: insert-license name: insert MIT license diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 41f54dd..308d694 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,7 +13,7 @@ work is not in vain. - Clone the repo `git clone https://github.com/deel-ai/deel-torchlip.git`. - Go to your freshly downloaded repo `cd deel-torchlip` - Create a virtual environment and install the necessary dependencies for development: - + `make prepare-dev && source torchlip_dev_env/bin/activate`. - You are ready to install the library: diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 8d6b630..9bc6a6a 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -12,7 +12,7 @@ These management rules are intended to be collaborative and all those involved i The governance committee is initially composed of DEEL members who contributed to the first version of `deel-torchlip` and are the only contributors to the master branch. -The governance committee is responsible for the master branch that contains the code of the version of the library that is officially recognised. +The governance committee is responsible for the master branch that contains the code of the version of the library that is officially recognised. These governance committee members are the only ones able to merge pull requests into this branch which from contributions branches. @@ -22,13 +22,13 @@ The governance committee identifies among the contributors who by their merits c ### Contributors -A contributor is anyone who comments any aspects relating to the project: comments on an issue or pull request, documentation, architecture, code and validation tests or anybody with a merged pull request. +A contributor is anyone who comments any aspects relating to the project: comments on an issue or pull request, documentation, architecture, code and validation tests or anybody with a merged pull request. All governance committee membres are contributors. ### Maintainers -All contributors with write rights (commit rigths) are maintainers. +All contributors with write rights (commit rigths) are maintainers. .... From 74dcef2d45b2006fc1a9dd29a83377e3cdc92048 Mon Sep 17 00:00:00 2001 From: cofri Date: Tue, 14 Jun 2022 11:08:28 +0200 Subject: [PATCH 2/3] fix: align PyTorch version in tox with requirements.txt --- setup.cfg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.cfg b/setup.cfg index 83a6a4c..6ec0a38 100644 --- a/setup.cfg +++ b/setup.cfg @@ -25,8 +25,8 @@ pip_version = pip>=20 deps = pytest torch_testing - torch==1.7.0+cpu - torchvision==0.8.1+cpu + torch==1.10.2+cu113 + torchvision==0.11.3+cu113 install_command = pip install --find-links https://download.pytorch.org/whl/torch_stable.html {opts} {packages} commands = pytest tests From 9bd99562b083ef4171e128ab6db75ba93603505c Mon Sep 17 00:00:00 2001 From: cofri Date: Wed, 8 Jun 2022 12:50:30 +0200 Subject: [PATCH 3/3] chore: remove NumPy fixed version in requirements NumPy<1.22.0 has a vulnerability (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-34141). This is an opportunity to remove the dependency to a specific version and to fetch the latest NumPy version. --- requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index 36be9e4..f6bd89a 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,5 +1,5 @@ torch_testing==0.0.2 inflection==0.5.1 -numpy==1.19.5 +numpy torch==1.10.2+cu113 torchvision==0.11.3+cu113