From 5f10dad85eef5b11565c1d0b30f2ecc5c941820b Mon Sep 17 00:00:00 2001 From: Franck Mamalet <49721198+franckma31@users.noreply.github.com> Date: Tue, 10 Dec 2024 10:04:18 +0100 Subject: [PATCH] remove same case for padding_mode to solve https://github.com/deel-ai/deel-torchlip/pull/23#discussion_r1868955134 and https://github.com/deel-ai/deel-torchlip/pull/23#discussion_r1868967430 --- deel/torchlip/modules/pooling.py | 1 - deel/torchlip/utils/lconv_norm.py | 12 ++---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/deel/torchlip/modules/pooling.py b/deel/torchlip/modules/pooling.py index d4ffae0..e9b3fce 100644 --- a/deel/torchlip/modules/pooling.py +++ b/deel/torchlip/modules/pooling.py @@ -232,4 +232,3 @@ def forward(self, input: torch.Tensor) -> torch.Tensor: def vanilla_export(self): return self - diff --git a/deel/torchlip/utils/lconv_norm.py b/deel/torchlip/utils/lconv_norm.py index 9feb1af..0101fdf 100644 --- a/deel/torchlip/utils/lconv_norm.py +++ b/deel/torchlip/utils/lconv_norm.py @@ -41,11 +41,7 @@ def compute_lconv_coef_1d( stride = strides[0] k1 = kernel_size[0] - if ( - (padding_mode in ["zeros", "same"]) - and (stride == 1) - and (input_shape is not None) - ): + if (padding_mode in ["zeros"]) and (stride == 1) and (input_shape is not None): # See https://arxiv.org/abs/2006.06520 in_l = input_shape[-1] k1_div2 = (k1 - 1) / 2 @@ -67,11 +63,7 @@ def compute_lconv_coef( stride = np.prod(strides) k1, k2 = kernel_size - if ( - (padding_mode in ["zeros", "same"]) - and (stride == 1) - and (input_shape is not None) - ): + if (padding_mode in ["zeros"]) and (stride == 1) and (input_shape is not None): h, w = input_shape[-2:] k1_div2 = (k1 - 1) / 2 k2_div2 = (k2 - 1) / 2