Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eval inline js issue in subshape #155

Closed
sinzii opened this issue Jul 2, 2024 · 0 comments · Fixed by #156
Closed

Fix eval inline js issue in subshape #155

sinzii opened this issue Jul 2, 2024 · 0 comments · Fixed by #156
Assignees
@sinzii
Labels
shape

Comments

@sinzii
Copy link
Member

sinzii commented Jul 2, 2024 •
edited
Loading

The object codec from subshape is currently using inline js.

This breaks the chrome extension on manifest v3, since inline js eval is not allowed as a security measure.

This is a good time for us to make a fork of subshape and put all of our customizations (@dedot/shape) there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sinzii sinzii

Labels
shape
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(shape): subshape -> deshape dedotdev/dedot
1 participant
@sinzii