Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fundrawtransaction JSON-RPC #1181

Closed
jrick opened this issue Jun 14, 2018 · 1 comment · Fixed by #1706
Closed

Implement fundrawtransaction JSON-RPC #1181

jrick opened this issue Jun 14, 2018 · 1 comment · Fixed by #1706
Assignees

Comments

@jrick
Copy link
Member

jrick commented Jun 14, 2018

This method is currently unimplemented, and should be implemented as part of the raw transaction JSON-RPC API.

The behavior should be similar to Bitcoin Core's implementation. Some differences that must be accounted for are:

  • The funding account must be specified as a non-optional parameter
  • Address types (for change) can likely be ignored, since we have a malleability fix for normal P2PKH
  • We don't have separate watching-only addresses in wallets with other private keys, so includeWatching makes little sense
  • RBF (BIP125) isn't implemented by dcrwallet and doesn't need support in this request
  • There is no fee rate estimation, so the estimate_mode parameter doesn't make sense
  • There is no segwit distinction in Decred, so the iswitness parameter is unnecessary
@vctt94
Copy link
Member

vctt94 commented Jun 15, 2018

Can I get this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants